Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests #125

Closed
k00ni opened this issue Jan 24, 2019 · 4 comments
Closed

Fix failing tests #125

k00ni opened this issue Jan 24, 2019 · 4 comments

Comments

@k00ni
Copy link
Collaborator

k00ni commented Jan 24, 2019

These block new PRs, because we can not guarantee, that no regressions are merged. We would appreciate any help here! Thanks in advance.

Ref:

@cbinding
Copy link
Contributor

Hi Konrad, thanks for following up - looking at one example https://github.com/semsol/arc2/blob/master/tests/db_adapter_depended/store/ARC2_StoreTest.php test 'testMultipleInsertQuerysInDifferentGraphs' which is currently failing - the assertion in the test itself appears to be incorrect. It inserts 1 triple into graph1 and 2 triples into graph2 but then asserts there should now be 1 triple in each graph - this test will always fail.

@cbinding
Copy link
Contributor

Looking at the next failing test https://github.com/semsol/arc2/blob/master/tests/db_adapter_depended/store/query/LoadQueryTest.php 'testLoad' - it is trying to load a file which is not present at the location given - the path https://raw.githubusercontent.com/semsol/arc2/master/tests/sparql11/w3c-tests/move/manifest.ttl returns 404 not found - so again this test will always fail as it cannot load this data. I think the 'correct' path should be https://raw.githubusercontent.com/semsol/arc2/master/tests/data/turtle/manifest.ttl
The tests are incorrect, that is why they are failing.

@cbinding
Copy link
Contributor

The 3rd (out of 3) failing test is just a variation on the 2nd, as it is attempting to load the same incorrect test data file path

k00ni added a commit that referenced this issue Jan 25, 2019
Fixing failing tests (issue #125)
@k00ni k00ni closed this as completed Jan 25, 2019
@k00ni
Copy link
Collaborator Author

k00ni commented Jan 25, 2019

Further discussion in related PR #126.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants