All QC Sample ID are same cross worksheet for version 2.4.0+

[erikking]

Description

When I want to import lab data (2d-csv format) for one worksheet with reference sample, the reference sample value cannot be importd whatever the reference sample ID / name in csv file.

So I checked Home -> Setup -> Suppliers -> Reference Samples -> Analyses, and found all QC sample ID are same cross worksheets.

Reproduction guide

1. add supplier
2. add reference sample
3. create multiple worksheets and add the reference sample above
4. check QC sample IDs in Home -> Setup -> Suppliers -> Reference Samples -> Analyses

Observed behaviour

For version 2.4.0, 2.4.1, 2.5.0, I got following QC Sample ID

Expected behaviour

For version <= 2.3.0

Versions

2.4.0+

[ramonski]

Hi @erikking,
Can you share your ID Server configuration?
Thanks

[erikking]

Thanks for you response @ramonski ,

I used same ID server config for different version.

And for version 2.4.0 +, the ID server values referencesample-ECS always = 1 after add reference sample in worksheet.

[ramonski]

Your split length must be 2, then it should work.

[ramonski]

Ah, apologies, I was looking at the generated ID ECS-001-001 with the two dashes.
We will try to reproduce this issue according to your description to see what is going on there.
Thanks.

[erikking]

Thanks a lot for your quick response. My ultimate goal is to import lab result file for worksheet with reference sample. For version 2.3.0, I can use reference sample ID ECS-001-007 with lab value for worksheet WS-020 in imported csv file for the example above, then importing works well and the reference sample lab value will show in worksheet page, but when I upgrade to 2.4.0+, I cannot find a way to import reference sample lab value.

[erikking]

Hi @ramonski
I did further investigation in source code about the the issue, I found ReferenceAnalysesGroupID do not change when add new reference control in worksheet. And a potential cause may be related ReferenceAnalysesGroupID generation function nextRefAnalysesGroupID in worksheet.
Could you help to check with that?

[erikking]

Hi @ramonski
I thought I figured it out, there may two cause

• in line 435 ids = [int(i.split(prefix)[1]) for i in ids if i and rr.match(i)] the ids always return emtpy
• in line 415 ref_analysis.reindexObject(idxs=["getWorksheetUID", "getAnalyst"]) need add getReferenceAnalysesGroupID to build the index because nextRefAnalysesGroupID function call the index to get distinct count of reference analyses group

Hope it helps.

[erikking]

And also the ReferenceAnalysesGroupID is same for duplication as well in worksheet

[ramonski]

Thanks @erikking for pointing out the code!
We will check this as soon as possible to find which fix is needed to make this work properly.
Best regards, Ramon

[ramonski]

Fixed in #2388

[erikking]

Very nice to hear it got fixed. 👍

[xispa]

Please @erikking close this issue after you double check. Thanks

[erikking]

Sure, sorry for the late close.