Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnalysisRequestDigester returns stale data #326

Closed
ramonski opened this issue Oct 28, 2017 · 3 comments
Closed

AnalysisRequestDigester returns stale data #326

ramonski opened this issue Oct 28, 2017 · 3 comments

Comments

@ramonski
Copy link
Contributor

Steps to reproduce

  • Publish an AR from "Domain A" and afterwards from "Domain B", e.g. localhost/127.0.0.1
  • Change the Lab information

Current behavior

  • URLs stick to Domain A
  • Lab data, e.g. the Name are not updated

Expected behavior

All data is equal to the real data in the system

From Gitter

 Another issue with the AnalysisRequestDigester cache. It stores virtual URLs which will have a negative effect when someone browses the LIMS under different virtual host names. E.g. on my dev machine which runs on http://localhost:6100 The report print want’s to access the images via http://localhost:8888 which comes from the productive machine.
So I cannot test with the copied productive Database correctly at the moment.
@ramonski
Copy link
Contributor Author

ramonski commented Oct 28, 2017

A better approach for caching would probably be to use plone.memoize.volatile with the store_on_context storage.

However, we should focus on how to avoid the need for caching at all. This is only possible if we avoid preparing data that might be eventually needed by someone somewhen and rather prepare the data only then when the user requests for it.

@ramonski
Copy link
Contributor Author

I would like to remove that digester completely and look for a better approach to tune the performance. IMO that digester is also responsible for the "Analyses without acquisition chain", because persistent objects are hold in a plain dictionary in there.

@ramonski
Copy link
Contributor Author

Closing in favor of the upcoming senaite.publisher replacement, which will replace the old report engine in one of the next versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant