Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to impersonate a subuser #551

Closed
thinkingserious opened this issue Oct 31, 2017 · 5 comments
Closed

Add the ability to impersonate a subuser #551

thinkingserious opened this issue Oct 31, 2017 · 5 comments
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

Please see the Python implementation for an example.

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 31, 2017
@stianpr
Copy link
Contributor

stianpr commented Jan 10, 2018

Would be nice to get this in. We currently have to extend the SendGrid class to add the on-behalf-of header. And the documentation is clearly wrong because it states that one has to prefix the username with subuser_ which doesnt work. One only need to add the username to that header. So the documentation should be fixed also.

@thinkingserious
Copy link
Contributor Author

Hi @stianpr!

Agreed! I can't wait until this reaches the top of the backlog.

@Jericho
Copy link

Jericho commented Feb 18, 2018

@stianpr I asked about the "subuser_" prefix and I was told that it's necessary. Your experience seem to indicate that it's not the case so I'm a little confused.

@thinkingserious It would be great if you could settle this question once and for all: is the subuser_ prefix necessary or not?

@stianpr
Copy link
Contributor

stianpr commented Feb 19, 2018

@Jericho @thinkingserious Well, during my testing and implementation of this it only worked without the subuser_ prefix. It would be nice to clarify this and fix the documentation (or the API) so that we know what to use.

@thinkingserious
Copy link
Contributor Author

@stianpr @Jericho,

You would replace subuser_ with the actual subuser name.

In our documentation (https://sendgrid.api-docs.io/v3.0/how-to-use-the-sendgrid-v3-api/on-behalf-of) we will be updating on-behalf-of: subuser_<username> to read as on-behalf-of: <username>.

Thanks!

@thinkingserious thinkingserious added status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap labels Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

No branches or pull requests

3 participants