-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGES #217
Comments
what are the changes benefits? |
Hi @adammenges, Here is one example: We would like to refactor the Mail Helper so that:
It could be that we can make those changes without a major breaking version bump, but in the case that we need to, we are trying to learn how this community would like to best communicate with us. Also, even it's not a breaking change, we would love more community collaboration on major changes. Please let me know if you would like further clarification and thanks for taking the time to reach out to us! |
I like the idea of an opt-in mailing list for communication. It'd have a higher signal/noise ratio than "watching" the repo on Github. If I got an email asking for feedback about specific changes I'd reply for sure, whereas I'd probably ignore an email from github telling me that a new issue had been opened. |
I'd say for execution, go with the dedicated Github issue. IMO, issues are more "front and centre" |
When an update for a package available, I will always go straight to GitHub to read release notes anyway. |
That's great feedback @pa-jama! I've updated our release checklist to include a line that emphasizes that we need to include specifics when making a breaking changes, both in the CHANGELOG and in the Releases section. Thanks again for taking the time to reach out to us and helping us improve the SendGrid experience :) |
As a result of your feedback and as a continuation of the execution of our long term roadmap, there will be breaking changes coming soon. The last time we had a major breaking change, it was for the implementation of v3 Web API support. We announced those changes here on GitHub along with some instructions on how to test and provide feedback.
The feedback we got was amazing, but we didn't quite get the amount or thoroughness of feedback we were hoping for.
We want to continue improving this iterative process, so we are reaching out to you for feedback in order to determine the optimum way to move forward as this library is designed to be community driven, SendGrid led.
Please take a moment to share your thoughts with us.
Following are some ideas we are considering, we will likely choose one from Execution and one from Communication, but not all of the items below.
Execution (for large changes):
Communication:
How do you prefer to get these announcements? Is this too much? Too little? Please let us know!!
As always, we are listening carefully and are looking forward to working with you.
Note: We will always follow the semver.org convention of using major point releases to signify breaking changes. Please DO NOT auto-update your dependencies. It is important to take a look at the CHANGELOG or releases to find out how the breaking changes will impact your code.
The text was updated successfully, but these errors were encountered: