Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple substitutions in one method call? #65

Closed
ridget opened this issue Jun 5, 2016 · 1 comment
Closed

Multiple substitutions in one method call? #65

ridget opened this issue Jun 5, 2016 · 1 comment
Labels
type: question question directed at the library

Comments

@ridget
Copy link

ridget commented Jun 5, 2016

Hi there,

Ive noted from the readme that the current way to handle multiple substitutions is to make multiple calls to add_substitution. Would there be any interest in supporting an add_substitutions method, which could take a hash and reduce the need to call this multiple times?

@thinkingserious
Copy link
Contributor

Hi @ridget,

I think that is a good idea, here is how we implement it now in the new library: https://github.com/sendgrid/sendgrid-csharp/blob/v3beta/SendGrid/SendGrid/Helpers/Mail/Mail.cs#L1272.

Are you interested in providing a pull request or would you like us to implement it? If it's the former, please sign our CLA and make your pull request against our v3beta branch, if it's the latter we will leave this ticket open and add it to our backlog.

Thanks!

Elmer

@thinkingserious thinkingserious added the type: question question directed at the library label Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: question question directed at the library
Projects
None yet
Development

No branches or pull requests

2 participants