Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] Audit and Fix all Markdown Pages #18

Closed
humphd opened this issue Oct 27, 2021 · 26 comments
Closed

[meta] Audit and Fix all Markdown Pages #18

humphd opened this issue Oct 27, 2021 · 26 comments

Comments

@humphd
Copy link
Contributor

humphd commented Oct 27, 2021

This is a meta issue, meant to organize the work necessary to audit and fix all existing markdown pages in docs/. If you want to work on this, the first step is to file a new issue for a given page and then leave a comment here with a link to the issue and name of the file you're working on.

Introduction

The IPC C notes are written in 30 Markdown files. These files have been automatically translated to Markdown:

A-Introduction

B-Computations

C-Data-Structures

D-Modularity

E-Secondary-Storage

F-Refinements

Resources-Appendices

Check List

When working on one of these pages, here are some things to consider

  • Look for any typos
  • Make sure all Markdown is correctly done. The conversion was done automatically by a tool, so there may be more idiomatic ways to do some things
  • Check the page in a Desktop browser. Does it look OK? Are there any issues that need to be fixed?
  • Check the page in a Mobile browser. Does it look OK? Are there any issues that need to be fixed?
  • Try the page in both Light and Dark mode. Are there any issues that need to be fixed?
  • Try running the page through Lighthouse: https://developers.google.com/web/tools/lighthouse. Are there any issues that need to be fixed?
  • Try running the page through Web Hint: https://webhint.io/. Are there any issues that need to be fixed?
  • Tables that are really wide (types.md) could be converted to use SVG or flex/grid. Make wide visual tables fit in the available viewport. Another example is the table in docs/D-Modularity/pointers.md, where we should reduce the vertical padding/margins on tables. The tables are too large, and probably shouldn't be tables at all.
  • Prefer Markdown tables vs. raw HTML tags
  • Fix colours in tables so it uses global styles vs. inline styles
  • Use alt tags for all images. See https://supercooldesign.co.uk/blog/how-to-write-good-alt-text for suggestions
  • Avoid blockquote for indentation, and prefer q or blockquote only when actually quoting. Use Admonitions instead. Example: docs/D-Modulatirty/pointers.md: there are places where > Blockquote are being used and Admonitions could replace it. “Note:” Lightbulb info Admonition.
  • Make sure images work in dark and light modes. For example, docs/8-Computations/logic.md Flags image is white background, needs to work in dark. Create a “negative” or SVG so we can do Dark Mode? Can we programmatically create this negative?
  • Change colours for tables (don’t use Yellow). We should use the default colour theme.
  • Avoid using <b> and <i> to do emphasis.
  • Use backticks and all code for memory addresses and such in tables that use things like void, int, function names, memory addresses.
  • Make sure all code blocks use syntax highlighting
  • centre images horizontally (esp. when they are small) so they work well at all responsive sizes
  • check sub-script and super-script that they are correctly used in all cases
  • consider including inter-site links to other pages that have related info
  • all links should have descriptive text for accessibility
  • Make sure that sub-headings (right-hand side) for each document are correct.
  • Improve readability of code comments (i.e., // and /*...*/) in dark mode (even light mode might need some work)
  • In places where ***...*** was used as a fourth heading level, use #### instead.
  • Fix Frontmatter for page to include proper id, title, slug, etc.

Filing Issues

If you notice issues that you can't, or don't want to fix, please file separate issues.

@humphd humphd pinned this issue Oct 27, 2021
@humphd
Copy link
Contributor Author

humphd commented Nov 1, 2021

To any OSD600/DPS909 students looking to get involved, this is a great issue to join. Let me know if you want to help out, and I'll assign you one of the pages.

@AndreWillomitzer
Copy link
Contributor

Hi sir I want to work on this but the checklist is a little overwhelming. These are just suggestions of what to look for right? For example we could go down the list, and if we find 3 or 4 to fix and they're smaller issues we could maybe let others handle some issues on the same page?

I am familiar with the C notes themselves since I tutored the class if that helps at all.

@humphd
Copy link
Contributor Author

humphd commented Nov 1, 2021

@AndreWillomitzer correct, these are the types of things we want to look at in the various files. Why don't you take one, and try looking for things, and see what you find. If there are 50 issues that have to be fixed, you could fix some, and file issues for others to fix in additional PRs. This will be a team sport!

It's awesome that you know the C notes so well, that will be a huge help. Thanks for diving in to help. Let me know which file you'll do, and file an issue to get started.

@AndreWillomitzer
Copy link
Contributor

AndreWillomitzer commented Nov 1, 2021

Hmmmm I think I will do "functions.md" but I'll have a look as well.

@AndreWillomitzer
Copy link
Contributor

Unless you have a suggestion of a page where you know there are a few things I will have to fix.

@humphd
Copy link
Contributor Author

humphd commented Nov 1, 2021

@AndreWillomitzer functions.md sounds good. Go ahead and file an issue for this, (you can copy/paste the text at the top of this, but limit it to that single file). I'll assign you.

@AndreWillomitzer
Copy link
Contributor

@humphd Hi sir I filed the issue. Which checks do you think would be the best to start with/most likely to have issues in the pages? I was thinking alt tags would be one.

@humphd
Copy link
Contributor Author

humphd commented Nov 1, 2021

@AndreWillomitzer just start working through and check as many as you can. Every page is different in terms of what it needs. Part of what you're doing at first is identifying the scope of the work.

@AndreWillomitzer
Copy link
Contributor

@humphd Not sure if what I found is really an issue or not, I notice on the pages some code is colored some is not. The huge blocks have syntax highlighting, but the single inline codes don't.

@humphd
Copy link
Contributor Author

humphd commented Nov 1, 2021

That's normal. You can't specify a syntax for single backtick inline blocks. Only the three-backtick ones have a syntax type.

@a-rokay
Copy link
Contributor

a-rokay commented Nov 4, 2021

I can work on input-functions.md, issue.

@joshuali7536
Copy link
Contributor

Hi I can work on computers.md, seen in issue #45

@roman-rezinkin
Copy link
Contributor

Hi, I can work on style-guidelines.md, as seen in #49

@dbelokon
Copy link
Contributor

dbelokon commented Nov 8, 2021

Hello!! Can I please work on structures.md page? #51 😁

@dhillonks
Copy link
Contributor

Can I work on functions-arrays-and-structs.md? #79

@RC-Lee
Copy link
Contributor

RC-Lee commented Nov 16, 2021

Hi, can I work on more-input-and-output.md #82 . Thanks!

@JiaHua-Zou
Copy link
Contributor

can I work on records-and-files.md mention on #85.

@abatomunkuev
Copy link
Contributor

Hello! I would like to work on testing-and-debugging.md, that is mentioned in issue #86

@MizuhoOkimoto
Copy link
Contributor

Hi! I would like to work on output-functions.md. I filed the issue in #87

@DerekJxy
Copy link

Hi! I would like to work on two-dimensional-arrays.md. As I mentioned in issue #88 .

@lmpham1 lmpham1 mentioned this issue Nov 17, 2021
25 tasks
@lmpham1
Copy link

lmpham1 commented Nov 17, 2021

Hello @humphd, I'd like to work on type.md.
Issue link: https://github.com/Seneca-ICTOER/IPC144/issues/90

@tcvan0707
Copy link

Hello @humphd, I would like to work on portability.md
Here is my issue: #94

@tpmai22
Copy link
Contributor

tpmai22 commented Nov 18, 2021

I can work on character-strings.md see #99 @humphd

@japneetsingh035
Copy link
Contributor

japneetsingh035 commented Nov 18, 2021

Did someone work on library-functions.md? if available, please let me know @humphd. Thank you!

@humphd
Copy link
Contributor Author

humphd commented Nov 18, 2021

@japneetsingh035, go for it, it's all yours.

@humphd
Copy link
Contributor Author

humphd commented Nov 25, 2021

At this stage, every document has been finished, started, or an issue is filed separately. Nice work everyone. Please follow-up in new issues. Closing.

@humphd humphd closed this as completed Nov 25, 2021
@humphd humphd unpinned this issue Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests