Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't run in Git for Windows Bash shell #13

Closed
SteveALee opened this issue Oct 22, 2015 · 9 comments
Closed

Doesn't run in Git for Windows Bash shell #13

SteveALee opened this issue Oct 22, 2015 · 9 comments

Comments

@SteveALee
Copy link

Seems to be a problem with the stdin

C:\Users\Steve\AppData\Roaming\nvm\v4.1.0\node_modules\seneca-in-practice\node_modules\workshopper\node_modules\terminal-menu\index.js:61
    process.stdin.setRawMode(true);
                  ^

TypeError: process.stdin.setRawMode is not a function
    at new Menu (C:\Users\Steve\AppData\Roaming\nvm\v4.1.0\node_modules\seneca-in-practice\node_modules\workshopper\node_modules\terminal-menu\index.js:61:19)
    at module.exports (C:\Users\Steve\AppData\Roaming\nvm\v4.1.0\node_modules\seneca-in-practice\node_modules\workshopper\node_modules\terminal-menu\index.js:8:12)
    at showMenu (C:\Users\Steve\AppData\Roaming\nvm\v4.1.0\node_modules\seneca-in-practice\node_modules\workshopper\menu.js:14:18)
    at Workshopper.printMenu (C:\Users\Steve\AppData\Roaming\nvm\v4.1.0\node_modules\seneca-in-practice\node_modules\workshopper\workshopper.js:311:14)
    at new Workshopper (C:\Users\Steve\AppData\Roaming\nvm\v4.1.0\node_modules\seneca-in-practice\node_modules\workshopper\workshopper.js:158:8)
    at Workshopper (C:\Users\Steve\AppData\Roaming\nvm\v4.1.0\node_modules\seneca-in-practice\node_modules\workshopper\workshopper.js:20:12)
    at Object. (C:\Users\Steve\AppData\Roaming\nvm\v4.1.0\node_modules\seneca-in-practice\runners.js:13:1)
    at Module._compile (module.js:434:26)
    at Object.Module._extensions..js (module.js:452:10)
    at Module.load (module.js:355:32)

Also running "winpty Seneca-in-practice" to get better terminal emulation returns

Error @2 starting Seneca-in-practice
@GlenTiki
Copy link
Member

What version of node are you trying to run this on? This issue seems to be related to https://github.com/substack/terminal-menu/issues/25

@SteveALee
Copy link
Author

I tried both 0.10.40 (x32) and then 4.1.0 (x64) as I suspected a node version issue given the error

I'm using nvm-windows to switch but that is most unlikely to cause this issue.

@SteveALee
Copy link
Author

Well it seems it should work. The following in a node 4.1.0 REPL in GfW Bash:

> process.stdin.isTTY
true
> process.stdin.setRawMode
[Function]

So perhaps the workshopper or terminal-menu modules are doing something weird?

@marcopiraccini
Copy link
Collaborator

Well, the error is from terminal-menu. It seems something related with this: nodejs/node#2333
Can you try other workshopper (e.g. learnyounode) with the same node /os set to confirm that?

@piccoloaiutante
Copy link
Member

Have you tried to run it in powershell?

@SteveALee
Copy link
Author

Have you tried to run it in powershell?

Yes it's fine, and also in cmd shell.
I can use it, just not in the Bash shell I sit in all day. Fee free to close this as "won't fix". :)

@marcopiraccini
Copy link
Collaborator

Just for curiosity...which shell are you using? This one? http://win-bash.sourceforge.net/

@SteveALee
Copy link
Author

No. It's the one that comes with Git for Windows. I'm not sure what exactly it is but it certainly appears that it's parentage is MinGW/MSYS. GitHub for windows also uses a version but I found that has been left behind Git for Windows.

@SteveALee
Copy link
Author

Ah yes, they appear to be pulling upstream from CVS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants