-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promise support for act/add/wrap #548
Comments
Please mention this plugin as an option. This is 2017. To hell with callbacks! |
Callbacks has still a performance benefit over Promises or Generators. Particularly in the transport layer performance is very important. There is no need to create a project for this. You can create a small abstraction to promisify all callbacks to promises but be careful that your http://senecajs.org/docs/tutorials/seneca-with-promises.html |
Sure, avoid stateful services and messing with Funny how Bluebird performs way (x4 or more) better than native promises! why-are-native-es6-promises-slower-and-more-memory-intensive-than-bluebird |
@kristianmandrup when I mean |
Okay, thanks for clearing that up! I recall looking at Seneca two years ago but didn't seem quite ready. Nice to see the progress since then! Ready to use it now, callbacks or not :) |
@kristianmandrup correct - you don't really run into too many callback problems with small services. |
My company has been using Seneca in production for over a year now, and we have relied on a custom plugin to add promise support to Seneca. Here is the github repo for the plugin:
seneca-as-promised
Since I see that you have plans to include promise support into the Seneca itself, I thought it would be a good idea to share my existing work in that direction. This plugin has been in production for a few months now, and we have not encountered any issues with it so far.
Speaking of which, I would also really appreciate any feedback in case this plugin is doing anything it shouldn't.
The text was updated successfully, but these errors were encountered: