Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WPE mode #4

Merged
merged 1 commit into from Feb 19, 2019
Merged

Add support for WPE mode #4

merged 1 commit into from Feb 19, 2019

Conversation

no0be
Copy link

@no0be no0be commented Feb 19, 2019

Add support for the hostapd-mana options allowing to intercept various EAP credentials:

  • mana_wpe
  • mana_eapsuccess
  • mana_eaptls

See wiki page for details.

@cablethief
Copy link
Member

cablethief commented Feb 19, 2019

Thank you, I meant to split the --mana flag into the separate flags just because you do not always want to run Mana attacks, just didn't have the time.
Will merge when I have checked it out.

@cablethief
Copy link
Member

I think I was going for simplest is best by only having the --mana flag, but I agree with this more. May mean really long commands however.

@no0be
Copy link
Author

no0be commented Feb 19, 2019

Thanks for the rapid feedback!

I feel like it makes more sense to split the EAP related options for targeted attacks against WPA-Enterprise. However, you could still add a --mana-all flag that enable all mana options to also have a simple option.

@cablethief
Copy link
Member

Will see how it works out, for now I rate this is better, will just neaten up the Mana options now cause they not as pretty as the wpe ones as the block of changes is now a single option. If I get feedback its too long then maybe we start adding convenience options like --mana-all

@cablethief cablethief merged commit 1c8e54a into sensepost:master Feb 19, 2019
@cablethief
Copy link
Member

I may change the options to follow that same

if [[ $MANA -eq 1 ]]; then

Logic, just because that was in the orig create_ap and seems to be everywhere. Also makes smaller hostapd configs if you choose to grab it from the created temp folder.

@cablethief
Copy link
Member

Also just want to ask @singe if there are any interactions that may break things, for example credout with wpe disabled. In which case those will fall under the same block

@no0be
Copy link
Author

no0be commented Feb 19, 2019

I did hesitate on where to place the additional config options. Indeed, a block such as the following might be cleaner.

if [[ $MANA_WPE -eq 1]]; then

It should be inside one of the $ENTERPRISE-related block though, as these options do not make any sense if --eap is not set.

@cablethief
Copy link
Member

Good point xD, let me look a bit closer.

@cablethief
Copy link
Member

Should of probably made a testing branch

@cablethief
Copy link
Member

Another option is when WPE is enabled to pull in all the normal EAP stuff forcing the requirement and shortening the commandline.

if [[ $ENTERPRISE -eq 0 ]] && [[ $MANA_WPE -eq 1 ]]; then
       <--- Would be put here
fi 

if [[ $ENTERPRISE -eq 1 ]] && [[ $MANA_WPE -eq 1 ]]; then
    cat << EOF >> $CONFDIR/hostapd.conf
mana_wpe=1
mana_credout=${MANA_CREDOUT}
EOF
fi

@no0be
Copy link
Author

no0be commented Feb 19, 2019

Or simpler, set ENTERPRISE to 1 if MANA_WPE is enabled prior generating hostapd.conf

if [[ $MANA_WPE -eq 1 ]]; then
   ENTERPRISE=1
fi

@cablethief
Copy link
Member

That is soooo much better xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants