Upgrade to msgpack-cpp 6.1.1 #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intend to replace this with a fork that reverts some changes for compatibility with pdf2msgpack.
This is so we can incorporate changes needed for a new pdf2msgpack release. The branch used has changes made in msgpack-cpp 4.1.2 reverted. This is because those changes result in floats and doubles getting packed as ints when the value after the decimal is zero. This breaks our current promise that values are floats. Alternative fixes might be: * change the specification, and downstream consumers have to convert ints to floats * overload the packer to handle floats and doubles in the previous way The current changes to msgpack-cpp are clean and do not require any other changes beyond reverting the relevant commits. The net effect is that the packing code for doubles and floats is exactly as it was in 4.1.1.
This was referenced Aug 7, 2023
|
Tested this out with lots of inputs, and doesn't look any different to the v0.7.0 version, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142.
This switches the vendored repository to a fork, for now. It should be reconsidered in future.
This is to work around the change of behaviour in msgpack-cpp in 4.1.2 as detailed in:
If floats and doubles have zero after a decimal point, msgpack-cpp in 4.1.2 and up packs them as ints.