Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to msgpack-cpp 6.1.1 #146

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Upgrade to msgpack-cpp 6.1.1 #146

merged 2 commits into from
Aug 7, 2023

Commits on Aug 7, 2023

  1. Remove vendored msgpack-c repository 

    Intend to replace this with a fork that reverts some changes for
compatibility with pdf2msgpack.
    @StevenMaude
    StevenMaude committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    9d71db3 View commit details
    Browse the repository at this point in the history

  2. Switch to sensiblecodeio fork of msgpack-cpp 

    This is so we can incorporate changes needed for a new pdf2msgpack
release.

The branch used has changes made in msgpack-cpp 4.1.2 reverted.
This is because those changes result in floats and doubles getting
packed as ints when the value after the decimal is zero.
This breaks our current promise that values are floats.

Alternative fixes might be:

* change the specification, and downstream consumers have to convert
  ints to floats
* overload the packer to handle floats and doubles in the previous way

The current changes to msgpack-cpp are clean and do not require any other
changes beyond reverting the relevant commits. The net effect is that
the packing code for doubles and floats is exactly as it was in 4.1.1.
    @StevenMaude
    StevenMaude committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    29bb22b View commit details
    Browse the repository at this point in the history