Added php7.4

[DonCallisto]

With php7.4 behind the corner, I tought it was good to try this against new version.

[DonCallisto]

It seems we'll need to wait for that phpspec/phpspec#1269 to be merged.
Do you prefer to keep this PR open or ... ?
Moreover we can also bump PHPSpec version to 6 (I've seen it won't add nothing useful for us, in case you agree I can open a different PR)

[jakzal]

Thanks for this! Such a shame we didn't manage to meet on SymfonyCon. I could've shown you the idea for new page-object library :(

[jakzal]

Also, would you mind to send this PR against the 2.3 branch?

[DonCallisto]

Thanks for this! Such a shame we didn't manage to meet on SymfonyCon. I could've shown you the idea for new page-object library :(

Yeah, what a pity!
Talk about this project in front of a beer would have been great. Maybe we'll get the chance at SymfonyCon2020 or if you apply for PHPDay Italy (I think the CFP is open).
BTW if you want to share some thoughs we can managed this online with slack or whatever.

Gonna change the base of PR ;)

[DonCallisto]

Done! :)

[jakzal]

Seems that there's no phpspec version that supports PHP 7.4 yet :(

[DonCallisto]

phpspec/phpspec#1269

[DonCallisto]

https://github.com/phpspec/phpspec/releases/tag/6.1.0

I think I can also bump PHPSpec version now on go on with this.
WDYT?

[jakzal]

Go for it. You'll probably need to drop PHP 7.1, which is fine.

[DonCallisto]

We're still in a showstopper situation, take a look --> BossaConsulting/phpspec2-expect#59

[DonCallisto]

Nevermind, they merged the PR. Let's check if CI is green.

Edit: Still no new tagged version yet :\

[DonCallisto]

WoW, huge of trouble with this version bumping 😄
Take a look at this FriendsOfPHP/Goutte#393

I know is related to --prefer-lowest composer flag but...

[DonCallisto]

Ok I've done also some other fixes (48f1fbc), now if on Goutte they raise Guzzle version we should be fine otherwise what would you do? I won't like the idea to drop --prefer-lowest check actually.

[jakzal]

What if we added a conflict with older versions of guzzle?

[DonCallisto]

How? Don’t understand the question.

[jakzal]

I'm talking about adding guzzle to the conflict section of composer.json. Not sure if it impacts --prefer-lowest though.

[DonCallisto]

Umh, don't know if that's gonna work but how about require Guzzle directly in our lib with the right version?
I know it's not a direct dependency but we can mitigate the problem unless a more restrictive version of Goutte will be released.
I really don't like this solution but I think would work.

[jakzal]

Yeah, one of the two should work :)

[DonCallisto]

conflict works like a charm. Didn't knew about it, thanks for sharing this.
BTW please check if I've introduced too strict version (I think I've not but let's double check)

[jakzal]

Thank you so much for working on this! 🍻