This repository has been archived by the owner on Jan 6, 2020. It is now read-only.
Remove decoration from forwarded exception #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
May 3, 2017
Composer/ScriptHandler.php
Outdated
| @@ -290,7 +290,7 @@ protected static function executeCommand(Event $event, $consoleDir, $cmd, $timeo | |||
| $process = new Process($php.($phpArgs ? ' '.$phpArgs : '').' '.$console.' '.$cmd, null, null, null, $timeout); | |||
| $process->run(function ($type, $buffer) use ($event) { $event->getIO()->write($buffer, false); }); | |||
| if (!$process->isSuccessful()) { | |||
| throw new \RuntimeException(sprintf("An error occurred when executing the \"%s\" command:\n\n%s\n\n%s.", escapeshellarg($cmd), $process->getOutput(), $process->getErrorOutput())); | |||
| throw new \RuntimeException(sprintf("An error occurred when executing the \"%s\" command:\n\n%s\n\n%s.", escapeshellarg($cmd), self::removeDecoration($process->getOutput()), self::removeDecoration($process->getErrorOutput()))); | |||
There was a problem hiding this comment.
having the dot at the end of the message (alone on its own line) after the command output looks quite weird actually. I would remove it.
The command output is very likely to include sentences anyway.
|
Trailing dot removed. |
HeahDude
approved these changes
May 3, 2017
|
What about removing the before after Am i missing something? |
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
May 11, 2017
This PR was merged into the 5.0.x-dev branch. Discussion ---------- Remove decoration from forwarded exception See symfony/symfony#22618 before  after  Commits ------- d5b9737 remove decoration from forwarded exception
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See symfony/symfony#22618
before
after
