moved version to a constant to avoid duplication

sensiolabs · Mar 9, 2017 · 8707499 · 8707499
1 parent 56bded6
commit 8707499
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/SensioLabs/Security/Crawler/CurlCrawler.php b/SensioLabs/Security/Crawler/CurlCrawler.php
@@ -12,6 +12,7 @@
 namespace SensioLabs\Security\Crawler;
 
 use SensioLabs\Security\Exception\RuntimeException;
+use SensioLabs\Security\SecurityChecker;
 
 /**
  * @internal
@@ -49,7 +50,7 @@ protected function doCheck($lock, $certFile)
         curl_setopt($curl, CURLOPT_SSL_VERIFYPEER, 1);
         curl_setopt($curl, CURLOPT_SSL_VERIFYHOST, 2);
         curl_setopt($curl, CURLOPT_CAINFO, $certFile);
-        curl_setopt($curl, CURLOPT_USERAGENT, 'SecurityChecker-CLI/4 CURL PHP');
+        curl_setopt($curl, CURLOPT_USERAGENT, sprintf('SecurityChecker-CLI/%s CURL PHP', SecurityChecker::VERSION));
 
         $response = curl_exec($curl);
 

diff --git a/SensioLabs/Security/Crawler/FileGetContentsCrawler.php b/SensioLabs/Security/Crawler/FileGetContentsCrawler.php
@@ -12,6 +12,7 @@
 namespace SensioLabs\Security\Crawler;
 
 use SensioLabs\Security\Exception\RuntimeException;
+use SensioLabs\Security\SecurityChecker;
 
 /**
  * @internal
@@ -33,7 +34,7 @@ protected function doCheck($lock, $certFile)
                 'follow_location' => true,
                 'max_redirects' => 3,
                 'timeout' => $this->timeout,
-                'user_agent' => 'SecurityChecker-CLI/4 FGC PHP',
+                'user_agent' => sprintf('SecurityChecker-CLI/%s FGC PHP', SecurityChecker::VERSION),
             ),
             'ssl' => array(
                 'cafile' => $certFile,

diff --git a/SensioLabs/Security/SecurityChecker.php b/SensioLabs/Security/SecurityChecker.php
@@ -17,6 +17,8 @@
 
 class SecurityChecker
 {
+    const VERSION = '4';
+
     private $vulnerabilityCount;
     private $crawler;
 

diff --git a/security-checker b/security-checker
@@ -27,6 +27,6 @@ use Symfony\Component\Console\Application;
 use SensioLabs\Security\Command\SecurityCheckerCommand;
 use SensioLabs\Security\SecurityChecker;
 
-$console = new Application('SensioLabs Security Checker', '4.0');
+$console = new Application('SensioLabs Security Checker', SecurityChecker::VERSION);
 $console->add(new SecurityCheckerCommand(new SecurityChecker()));
 $console->run();