Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

Use composer/ca-bundle for certificates checks #77

Merged
merged 1 commit into from
Mar 31, 2017

Conversation

tucksaun
Copy link
Contributor

@tucksaun tucksaun commented Mar 31, 2017

Should fix #75

@tucksaun tucksaun requested a review from fabpot March 31, 2017 09:59
@jenkoian
Copy link

This doesn't seem to have fixed the issue on travis for me (re. #75) see https://travis-ci.org/jenkoian/flysystem-gaufrette/builds/217122781

@graemechapman
Copy link

@tucksaun I have just tried running your branch through Travis CI, unfortunately this hasn't resolved the issue. Still receiving
An error occurred: gnutls_handshake() failed: A TLS fatal alert has been received..

@tucksaun
Copy link
Contributor Author

This should fix the An error occurred: SSL: certificate verification failed (result: 5)., I'll have a look for the other one.

@gabeguz
Copy link

gabeguz commented Mar 31, 2017

Hmm... strangely, this fixes the issue on my local dev environment, but not on circleci:

$ cd vendor/sensio-labs/security-checker
$ curl https://github.com/sensiolabs/security-checker/pull/77.patch > 77.patch
$ patch -p1 < 77.patch
$ composer install
$ ./security-checker security:check ./composer.lock

  An error occurred: gnutls_handshake() failed: A TLS fatal alert has been received..

@tucksaun
Copy link
Contributor Author

@jenkoian thanks for your build link, it helped me to reproduce it and iterate on it :)

So we actually hit two issues here: one is because some distributions can have an empty CA bundle and thus can not check the certificate, this PR is fixing this case.

The other one is that PHP build by Travis can not negotiate TLS handshake (see travis-ci/travis-ci#6339). And we can't do anything from here. I tried several SSL version settings and nothing worked.
As we are hand tied here, we came up with another solution with @fabpot: we now allow HTTP traffic on http://security.sensiolabs.org/check_lock only, so you can use security-checker security:check --end-point=http://security.sensiolabs.org/check_lock.

Travis-CI or circle-ci now needs to update their builds.

@fabpot
Copy link
Member

fabpot commented Mar 31, 2017

Thank you @tucksaun.

@fabpot fabpot merged commit 204c3ba into sensiolabs:master Mar 31, 2017
fabpot added a commit that referenced this pull request Mar 31, 2017
This PR was merged into the 4.0-dev branch.

Discussion
----------

Use composer/ca-bundle for certificates checks

Should fix #75

Commits
-------

204c3ba Use composer/ca-bundle for certificates checks
@graemechapman
Copy link

Many thanks @tucksaun, this is working now in my Travis builds by using the http end-point.

@gabeguz
Copy link

gabeguz commented Mar 31, 2017

Reported this issue to circleci as well.

arothuis pushed a commit to OpenConext/OpenConext-engineblock that referenced this pull request Apr 11, 2017
The SensioLabs security checker has switched to Lets Encrypt, which has broken some things

Most issues have been fixed, but Travis still needs to offer ssl capabilities to PHP

See: https://github.com/sensiolabs/security-checker/issues/73, travis-ci/travis-ci#6339, sensiolabs/security-checker#77 (comment)
arothuis pushed a commit to ibuildingsnl/qa-tools that referenced this pull request Apr 19, 2017
The SensioLabs security checker has switched to Lets Encrypt, which has broken some things

Most issues have been fixed, but Travis still needs to offer ssl capabilities to PHP

See: https://github.com/sensiolabs/security-checker/issues/73, travis-ci/travis-ci#6339, sensiolabs/security-checker#77 (comment)
abuadella pushed a commit to abuadella/ammit that referenced this pull request Apr 27, 2017
Otherwise An error occurred: gnutls_handshake() failed: A TLS fatal alert has been received...
See sensiolabs/security-checker#77
abuadella pushed a commit to abuadella/ammit that referenced this pull request Apr 27, 2017
Otherwise An error occurred: gnutls_handshake() failed: A TLS fatal alert has been received...
See sensiolabs/security-checker#77
gmorel pushed a commit to ammit-php/ammit that referenced this pull request Apr 27, 2017
Otherwise An error occurred: gnutls_handshake() failed: A TLS fatal alert has been received...
See sensiolabs/security-checker#77
ryota-murakami added a commit to laststance/trueblue that referenced this pull request May 9, 2017
ryota-murakami added a commit to laststance/trueblue that referenced this pull request May 9, 2017
jorissteyn pushed a commit to OpenConext-Attic/OpenConext-engineblock-metadata that referenced this pull request Jun 22, 2017
Travis builds fail with the error message:

    An error occurred: gnutls_handshake() failed: A TLS fatal alert has
    been received.

Until a version of security checker is available which fixes this issue,
we use a http endpoint.

See: sensiolabs/security-checker#77
mdeletter added a commit to SURFnet/grouphub.api that referenced this pull request Oct 6, 2017
Downgrading to HTTP is a (temporary) fix and should be removed once TLS
is supported on Travis.

See:
travis-ci/travis-ci#6339
sensiolabs/security-checker#77 (comment)
mdeletter added a commit to SURFnet/grouphub that referenced this pull request Oct 9, 2017
Downgrading to HTTP is a (temporary) fix and should be removed once TLS
is supported on Travis.

See:
travis-ci/travis-ci#6339
sensiolabs/security-checker#77 (comment)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A TLS fatal alert has been received..
5 participants