Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosted Assets should use organization namespace #90

Closed
mbiang opened this issue Feb 5, 2019 · 8 comments
Closed

Hosted Assets should use organization namespace #90

mbiang opened this issue Feb 5, 2019 · 8 comments
Assignees
Labels
bug Something isn't working ready to deploy

Comments

@mbiang
Copy link

mbiang commented Feb 5, 2019

** Current Behavior: **

Hosted assets currently are located under the namespace of the user that uploaded them. For example: https://bonsai.sensu.io/assets/portertech/sensu-jira-handler

** Desired Behavior **

@mbiang mbiang added the bug Something isn't working label Feb 5, 2019
@pzupan
Copy link

pzupan commented Feb 5, 2019

Changes are in pull request #93

@mbiang
Copy link
Author

mbiang commented Feb 12, 2019

The URL appears to be producing a 404 Not Found error: https://bonsai.sensu.io/assets/sensu/sensu-jira-handler

Also, if you click on the Sensu Jira Handler asset from the search results still doesn't load

@mbiang mbiang reopened this Feb 12, 2019
@mbiang
Copy link
Author

mbiang commented Feb 12, 2019

Here's a few more requirements I think will need to be implemented here:

  • The asset should not be available under the uploading user's namespace: https://bonsai.sensu.io/assets/portertech/sensu-jira-handler. This is to prevent duplicate content issues with Search Engine optimization. The site should show a 404 if the URL above is accessed.
  • The asset should display at under the organization's namespace by default, without redirecting to another location.

@pzupan
Copy link

pzupan commented Feb 12, 2019

Treating the asset as owned by Sensu causes some issues with the owner's asset page. Currently we are displaying the asset as owned by the individual on the individual's asset page. Do we want to change that as well?

@mbiang
Copy link
Author

mbiang commented Feb 12, 2019

Yes, that's a good catch - we don't want to show it there either. For all intents and purposes, this asset should be owned by Sensu. Do we need to rearchitect this a bit so that the user doesn't actually own the asset, but an org does? Not exactly sure how that would look.

@pzupan
Copy link

pzupan commented Feb 12, 2019

I think the only way we can do that is to re-architect it to create a sensu owner object. Then I suspect that object would have to be part of an organization such that other members of that organization will have admin privileges. It seems like a lot of work, but may be necessary since the asset should survive the dis-association of an individual from the organization leaving other individuals able to administer it.

Or perhaps we simply filter hosted assets from an individual's page and allow an administrator to transfer ownership of a hosted asset to another individual when necessary. This would leave the site with no owner page for hosted assets (or we could patch one together for all hosted assets).

@pzupan
Copy link

pzupan commented Feb 13, 2019

Pull request #104

@pzupan
Copy link

pzupan commented Feb 15, 2019

New Pull Request #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready to deploy
Projects
None yet
Development

No branches or pull requests

2 participants