Fix db deadlock when running multiple instances at once #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! makes sense since every command in the pipeline starts at once |
|
how does it work for you with this? https://github.com/sentriz/cliphist/releases/tag/v0.3.1 |
|
It's working flawlessly here, so far. |
|
Works for me too. Thanks for being so quick! P.S. Figured out my issue with vendoring: was using Go 1.17 instead of 1.16 |
|
nice! thanks for the patch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I ran into #24 and the timeout fix is a bit hacky. Unfortunately I can't build the latest commit (when using vendoring), so I'm opening this PR targeting an older commit just to show you how this can be properly fixed.
Basically there's a race for locking the DB, so the solution is closing it earlier, and opening it later. More specifically, before writing to/after reading from stdout/stdin is done so the process earlier/later in the shell pipeline has exited (or at least unlocked).
I hope you can port this to the latest commit and make a new release.
Thanks!