Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add flag to limit preview size #88

Merged
merged 1 commit into from
Feb 23, 2024
Merged

feat: add flag to limit preview size #88

merged 1 commit into from
Feb 23, 2024

Conversation

mtvrsh
Copy link
Contributor

@mtvrsh mtvrsh commented Feb 23, 2024

No description provided.

@sentriz
Copy link
Owner

sentriz commented Feb 23, 2024

thanks! can you add a test please using https://github.com/rogpeppe/go-internal/testscript

@sentriz
Copy link
Owner

sentriz commented Feb 23, 2024

could we also use the name preview-width , I think that's a little nicer

@mtvrsh
Copy link
Contributor Author

mtvrsh commented Feb 23, 2024

Ok, so I added randstr helper because I couldn't get rand to emit fixed width strings.
Let me know if I missed any test cases.

@sentriz sentriz merged commit 4714de1 into sentriz:master Feb 23, 2024
1 check passed
@sentriz
Copy link
Owner

sentriz commented Feb 23, 2024

very nice, thanks!

@sentriz sentriz mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtvrsh @sentriz