Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mix #25

Closed
wants to merge 2 commits into from
Closed

update mix #25

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da46c5e
update mix
ikeikeikeike Jun 18, 2017
e9433e2
Back to 1.3 and fix latest version to idna
Jun 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mix.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ defmodule PublicSuffix.Mixfile do
def project do
[app: :public_suffix,
version: "0.5.0",
elixir: "~> 1.2",
elixir: ">= 1.2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This declares that this library is compatible with all future versions of Elixir. We don't know that. 2.0 is going to have breaking changes and it's unlikely that existing published versions of this library will be compatible. Please change this back to ~> 1.2.

build_embedded: Mix.env == :prod,
start_permanent: Mix.env == :prod,
aliases: aliases(),
Expand All @@ -26,7 +26,7 @@ defmodule PublicSuffix.Mixfile do

defp deps do
[
{:idna, ">= 1.2.0 and < 3.0.0"},
{:idna, ">= 1.2.0 and <= 5.0.2"},
Copy link
Contributor

@myronmarston myronmarston Jun 18, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you happen to know what differs for 3.x vs 4.x vs 5.x? Usually major version bumps mean there are breaking changes and I wonder if we're actually compatible...

# ex_doc and earmark are necessary to publish docs to hexdocs.pm.
{:ex_doc, ">= 0.0.0", only: :dev},
{:earmark, ">= 0.0.0", only: :dev},
Expand Down
7 changes: 4 additions & 3 deletions mix.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
%{"earmark": {:hex, :earmark, "0.2.1", "ba6d26ceb16106d069b289df66751734802777a3cbb6787026dd800ffeb850f3", [:mix], []},
"ex_doc": {:hex, :ex_doc, "0.11.5", "0dc51cb84f8312162a2313d6c71573a9afa332333d8a332bb12540861b9834db", [:mix], [{:earmark, "~> 0.1.17 or ~> 0.2", [hex: :earmark, optional: true]}]},
"idna": {:hex, :idna, "1.2.0", "ac62ee99da068f43c50dc69acf700e03a62a348360126260e87f2b54eced86b2", [:rebar3], []}}
%{"earmark": {:hex, :earmark, "0.2.1", "ba6d26ceb16106d069b289df66751734802777a3cbb6787026dd800ffeb850f3", [:mix], [], "hexpm"},
"ex_doc": {:hex, :ex_doc, "0.11.5", "0dc51cb84f8312162a2313d6c71573a9afa332333d8a332bb12540861b9834db", [:mix], [{:earmark, "~> 0.1.17 or ~> 0.2", [hex: :earmark, repo: "hexpm", optional: true]}], "hexpm"},
"idna": {:hex, :idna, "5.0.2", "ac203208ada855d95dc591a764b6e87259cb0e2a364218f215ad662daa8cd6b4", [:rebar3], [{:unicode_util_compat, "0.2.0", [hex: :unicode_util_compat, repo: "hexpm", optional: false]}], "hexpm"},
"unicode_util_compat": {:hex, :unicode_util_compat, "0.2.0", "dbbccf6781821b1c0701845eaf966c9b6d83d7c3bfc65ca2b78b88b8678bfa35", [:rebar3], [], "hexpm"}}