update mix #25
update mix #25
Conversation
mix.exs
Outdated
| @@ -4,7 +4,7 @@ defmodule PublicSuffix.Mixfile do | |||
| def project do | |||
| [app: :public_suffix, | |||
| version: "0.5.0", | |||
| elixir: "~> 1.2", | |||
| elixir: ">= 1.2.0", | |||
There was a problem hiding this comment.
This declares that this library is compatible with all future versions of Elixir. We don't know that. 2.0 is going to have breaking changes and it's unlikely that existing published versions of this library will be compatible. Please change this back to ~> 1.2.
mix.exs
Outdated
| @@ -26,7 +26,7 @@ defmodule PublicSuffix.Mixfile do | |||
|
|
|||
| defp deps do | |||
| [ | |||
| {:idna, ">= 1.2.0 and < 3.0.0"}, | |||
| {:idna, ">= 1.2.0 and <= 5.0.2"}, | |||
There was a problem hiding this comment.
Do you happen to know what differs for 3.x vs 4.x vs 5.x? Usually major version bumps mean there are breaking changes and I wonder if we're actually compatible...
|
Thanks response and review comment. I apologize that I don't know IDNA compatible between 1.2(3.0) and 5.0. But just know I appreciate this PR is merged if you will be accepted. |
| @@ -26,7 +26,7 @@ defmodule PublicSuffix.Mixfile do | |||
|
|
|||
| defp deps do | |||
| [ | |||
| {:idna, ">= 1.2.0 and < 3.0.0"}, | |||
| {:idna, "~> 5.0"}, | |||
There was a problem hiding this comment.
This requires that every user of this library upgrade idna to 5.x, but that might be difficult if they have other dependencies that rely on earlier versions. Can you change this to ">= 1.2.0 and < 6.0.0" so that 5.x versions are supported but not required?
|
This was obsoleted by #26 and can be closed. |
I'm trying to use this package for package's development with
override: trueoption in mix.exs.But I've got this result below due to be set idna(override: true) and httpoison over than
0.11.1version to mix.exs.Supposedly, hex.pm cannot accept that option. So please update package version!!
Thanks awesome package.