Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BF+TST: Fix issues with bytes/unicode when diffing text (issue #60) #61

Merged
merged 3 commits into from
Apr 11, 2017
Merged

BF+TST: Fix issues with bytes/unicode when diffing text (issue #60) #61

merged 3 commits into from
Apr 11, 2017

Conversation

moloney
Copy link

@moloney moloney commented Mar 15, 2017

Code was assuming text is always the default type (bytes in Python2
and unicode in Python3).

BF+TST: Fix issues with bytes/unicode when diffing text
a28ad17 
Code was assuming text is always the default type (bytes in Python2
and unicode in Python3).
@coveralls
Copy link

coveralls commented Mar 15, 2017 •
edited

Coverage Status

Coverage decreased (-0.3%) to 99.747% when pulling a28ad17 on moloney:bf-issue-60 into d386628 on seperman:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 99.747% when pulling cc5b792 on moloney:bf-issue-60 into d386628 on seperman:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 99.747% when pulling cc5b792 on moloney:bf-issue-60 into d386628 on seperman:master.

@coveralls
Copy link

coveralls commented Mar 16, 2017 •
edited

Coverage Status

Coverage decreased (-0.3%) to 99.747% when pulling cc5b792 on moloney:bf-issue-60 into d386628 on seperman:master.

BF+TST: Fix newly introduced bug when non-ascii bytes encoutered
db68363 
Fix test to actually use non-ascii bytes (doh!), and fix isse that
was revealed from this test.
@coveralls
Copy link

coveralls commented Mar 16, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling db68363 on moloney:bf-issue-60 into d386628 on seperman:master.

@seperman
Copy link
Owner

Hi @moloney
Thanks for the PR. Looking into it.

@seperman seperman self-assigned this Apr 11, 2017
@seperman seperman merged commit 25f7e71 into seperman:master Apr 11, 2017
@seperman
Copy link
Owner

👍

@moloney moloney mentioned this pull request May 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@seperman seperman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moloney @coveralls @seperman