Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Models for request fields should be separated #11

Closed
LimpidCrypto opened this issue Jul 14, 2022 · 0 comments · Fixed by #9
Closed

DEV: Models for request fields should be separated #11

LimpidCrypto opened this issue Jul 14, 2022 · 0 comments · Fixed by #9
Assignees
@LimpidCrypto
Labels
enhancement New feature or request

Comments

@LimpidCrypto
Copy link
Collaborator

LimpidCrypto commented Jul 14, 2022 •
edited
Loading

To avoid confusion the field structs like Directory, DepositPreauth, Offer, etc., which are currently defined in mod.rs, should be separated to a new file. There are Ledger Objects that have the same name but different fields. Also there is a DepositPreauth transaction.

I separated them in #9 for now.
@LimpidCrypto LimpidCrypto added the enhancement New feature or request label Jul 14, 2022
@LimpidCrypto LimpidCrypto linked a pull request Jul 14, 2022 that will close this issue
add Model trait #9
Merged
11 tasks
@LimpidCrypto LimpidCrypto self-assigned this Jul 14, 2022
@LimpidCrypto LimpidCrypto mentioned this issue Jul 14, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LimpidCrypto LimpidCrypto

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add Model trait LimpidCrypto/xrpl-rust
1 participant
@LimpidCrypto