Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested improvements #3

Closed
johnnybubonic opened this issue Jan 3, 2019 · 0 comments
Closed

Suggested improvements #3

johnnybubonic opened this issue Jan 3, 2019 · 0 comments

Comments

@johnnybubonic
Copy link

johnnybubonic commented Jan 3, 2019

Hey, I have some suggestions you may want to implement:

  • Python 3 compatibility
    ** Python 2 EOLs on January 1, 2020.
    ** The 2to3 utility should fix this right up. I can submit a PR or patch, however, if you prefer.

  • OpenLDAP's /etc/openldap/ldap.conf/~/.ldaprc support
    ** /etc/pam_ldap.conf is deprecated in CentOS 7 and relevant releases on other distros.
    ** Either nslcd.conf syntax should instead be used, or the ldap.conf/.ldaprc file syntax should. The benefit of the latter is they allow per-user configuration and further TLS options (such as minimum required TLS version). The advantage of the former is it's a little closer to the obsolete pam_ldap.conf syntax and allow you to contain passwords in plaintext.
    *** If the ldap.conf is used, then a new argument should be created allowing one to specify a path to the password file (the -y argument for e.g. ldapsearch) (newline characters should not be stripped from this)

If you'd like, I can offer a PR for this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant