Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Update CI #46

Merged
merged 1 commit into from
May 10, 2021
Merged

[INFRA] Update CI #46

merged 1 commit into from
May 10, 2021

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented May 7, 2021

Pull changes from SeqAn3 CI

  • Split CI into 3 workflows.
  • Documentation build still uploads the built documentation as artifact.
  • Use codecov action for uploading.

Updated doxygen

  • Now uses compact version of config, that is why there is a huge diff.
  • Some things were reordered when updating the doxygen config from 1.8.x to 1.9.1. This is probably due to manual reordering done when the config was added.

Use ccache

  • We actually never used ccache :)
  • Uses the cmake from SeqAn3 to detect and add ccache.

Misc

  • Coverage cmake checked for DEBUG build type; correct is Debug.
  • Minor include fixes in the tests.

@eseiler eseiler force-pushed the infra/update_ci2 branch 7 times, most recently from e3e0d05 to 9350e27 Compare May 7, 2021 11:26
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #46 (61d0d88) into master (484b661) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #46   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           19        19           
=========================================
  Hits            19        19           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 484b661...61d0d88. Read the comment docs.

@eseiler eseiler requested a review from Irallia May 7, 2021 11:26
@eseiler eseiler force-pushed the infra/update_ci2 branch 2 times, most recently from a47d86d to 7384dc9 Compare May 7, 2021 11:34
Copy link
Contributor

@Irallia Irallia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM, thanks for cleaning up! I like the concise yml files ❤️
I've just a question about the build modes. Why don't we check the debug mode in another case (besides the coverage)?

.github/workflows/ci_linux.yml Show resolved Hide resolved
Copy link
Member

@marehr marehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

uses: Homebrew/actions/setup-homebrew@master

- name: Install CMake
run: bash ./src/lib/seqan3/.github/workflows/scripts/install_cmake.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: bash ./src/lib/seqan3/.github/workflows/scripts/install_cmake.sh
run: bash ./src/lib/seqan3/.github/workflows/scripts/install_cmake.sh ${cmake_version}

not needed now, but I would prefer if we pass the version explicitly :)

@@ -2,3 +2,6 @@

To build the API documentation, you need to install `doxygen`. We use Doxygen version 1.8.17.
Run `make doc` and open the API documentation via `open doc/html/index.html`.

You can run `doxygen -u doxygen_cfg` to convert the configuration file to its verbose version.
`doxygen -u -s doxygen_cfg` will convert it back to its compact version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice comment :)

@marehr marehr merged commit f9d4c70 into seqan:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants