Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] handle short read data #175

Merged
merged 4 commits into from
Oct 26, 2021

Conversation

Irallia
Copy link
Collaborator

@Irallia Irallia commented Oct 25, 2021

Resolves #27

We use cigar and split read method for short reads aswell.
I added a new test case for this (combination of short and long reads)
I also found a small mistake in the paired end SAM file, which gets fixed aswell.

@Irallia Irallia self-assigned this Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #175 (e71b6b6) into master (272ea6a) will increase coverage by 0.14%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   96.95%   97.09%   +0.14%     
==========================================
  Files          19       19              
  Lines         853      862       +9     
==========================================
+ Hits          827      837      +10     
+ Misses         26       25       -1     
Impacted Files Coverage Δ
src/variant_detection/variant_detection.cpp 95.65% <90.90%> (+1.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 272ea6a...e71b6b6. Read the comment docs.

Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
@Irallia Irallia force-pushed the FEATURE/handle_short_read_data branch from e1c1e23 to ba81aa1 Compare October 25, 2021 13:13
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
@Irallia Irallia force-pushed the FEATURE/handle_short_read_data branch from ba81aa1 to 71a12d4 Compare October 25, 2021 13:26
@Irallia Irallia requested review from a team and eaasna and removed request for a team October 25, 2021 13:34
Copy link
Contributor

@eaasna eaasna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Irallia Irallia requested a review from joergi-w October 25, 2021 13:54
test/cli/iGenVar_cli_test.cpp Show resolved Hide resolved
test/cli/iGenVar_cli_test.cpp Outdated Show resolved Hide resolved
test/cli/iGenVar_cli_test.cpp Outdated Show resolved Hide resolved
test/data/mini_example/output_short_and_long_err.txt Outdated Show resolved Hide resolved
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
@Irallia Irallia requested a review from joergi-w October 25, 2021 16:13
Copy link
Member

@joergi-w joergi-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Irallia Irallia merged commit ebcefda into seqan:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Call SVs in short reads via the CIGAR string and SA tag
3 participants