Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alphabet_base should expect that char_to_rank, rank_to_char, ... are static member functions. #295

Closed
5 tasks done
marehr opened this issue Mar 3, 2021 · 1 comment
Closed
5 tasks done

alphabet_base should expect that char_to_rank, rank_to_char, ... are static member functions. #295

marehr opened this issue Mar 3, 2021 · 1 comment
Assignees
@marehr
Milestone
3.0.3 2nd Release...

Comments

@marehr
Copy link
Member

marehr commented Mar 3, 2021 •
edited
Loading

Core Meeting 2021-02-15:

  • We talked about making the look-up tables static functions, so that we can make use cases like [Alphabet] dna4 complement and SIMD seqan3#1970 possible. We can still use look-up tables within the functions itself if we want to.
  • rank_to_char table to function
  • char_to_rank table to function
  • complement table to function
  • add CHANGELOG

Originally posted by @marehr in #269 (comment)
@marehr marehr mentioned this issue Mar 3, 2021
Merged
@marehr marehr changed the title alphabet_base should expect that char_to_rank, rank_to_char are static member functions. alphabet_base should expect that char_to_rank, rank_to_char, ... are static member functions. Mar 4, 2021
@marehr marehr mentioned this issue Mar 4, 2021
Closed
@marehr marehr added this to the 3.0.3 Release Sprint milestone Apr 13, 2021
@marehr marehr self-assigned this Apr 26, 2021
@marehr marehr mentioned this issue May 1, 2021
Merged
@marehr
Copy link
Member Author

marehr commented May 6, 2021

closed by seqan/seqan3#2584

@marehr marehr closed this as completed May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marehr marehr

Labels
None yet
Projects
None yet
Milestone
3.0.3 2nd Release Sprint
Development

No branches or pull requests
1 participant
@marehr