Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nucleotide_base complement table static member functions #2584

Merged
merged 5 commits into from
May 4, 2021

Conversation

marehr
Copy link
Member

@marehr marehr commented May 1, 2021

@marehr marehr requested review from a team and SGSSGene and removed request for a team May 1, 2021 00:06
@vercel
Copy link

vercel bot commented May 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/9NDQXEaMdmH7APLd31Vkk3uTmr76
✅ Preview: https://seqan3-git-fork-marehr-complementtable-seqan.vercel.app

@codecov
Copy link

codecov bot commented May 1, 2021

Codecov Report

Merging #2584 (31ab753) into master (08578f0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 31ab753 differs from pull request most recent head 26888c0. Consider uploading reports for the commit 26888c0 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2584   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         270      269    -1     
  Lines       10570    10577    +7     
=======================================
+ Hits        10384    10391    +7     
  Misses        186      186           
Impacted Files Coverage Δ
include/seqan3/alphabet/nucleotide/dna15.hpp 100.00% <100.00%> (ø)
include/seqan3/alphabet/nucleotide/dna16sam.hpp 100.00% <100.00%> (ø)
include/seqan3/alphabet/nucleotide/dna3bs.hpp 100.00% <100.00%> (ø)
include/seqan3/alphabet/nucleotide/dna4.hpp 100.00% <100.00%> (ø)
include/seqan3/alphabet/nucleotide/dna5.hpp 100.00% <100.00%> (ø)
...ude/seqan3/alphabet/nucleotide/nucleotide_base.hpp 100.00% <100.00%> (ø)
include/seqan3/alphabet/nucleotide/rna15.hpp 100.00% <100.00%> (ø)
include/seqan3/alphabet/nucleotide/rna4.hpp 100.00% <100.00%> (ø)
include/seqan3/alphabet/nucleotide/rna5.hpp 100.00% <100.00%> (ø)
...clude/seqan3/alignment/pairwise/align_pairwise.hpp 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c9e01b...26888c0. Read the comment docs.

Copy link
Member

@eseiler eseiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just changelog re-write suggestion

Edit: I had this tab open when I did reviews, so you get the second review too early... :)

CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants