Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] introduce new concepts seqan3::detail::(writable_)pairwise_alignment #2359

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

marehr
Copy link
Member

@marehr marehr commented Jan 28, 2021

This PR resolves seqan/product_backlog#60 task
by implementing seqan3::detail::(writable_)pairwise_alignment.

@marehr marehr requested review from a team and Irallia and removed request for a team January 28, 2021 22:50
@marehr marehr force-pushed the concept_for_alignment branch 2 times, most recently from b64e766 to 89cedee Compare February 2, 2021 10:54
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #2359 (b32a1d2) into master (e7e0430) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2359   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files         264      264           
  Lines       10784    10784           
=======================================
  Hits        10591    10591           
  Misses        193      193           
Impacted Files Coverage Δ
...ment/aligned_sequence/aligned_sequence_concept.hpp 100.00% <ø> (ø)
include/seqan3/io/alignment_file/detail.hpp 96.92% <ø> (ø)
include/seqan3/io/record.hpp 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7e0430...b32a1d2. Read the comment docs.

@marehr marehr removed the request for review from Irallia February 3, 2021 12:39
@marehr
Copy link
Member Author

marehr commented Feb 4, 2021

@Irallia This is now ready to review ❤️

Copy link
Contributor

@Irallia Irallia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM, thank you!

@Irallia Irallia requested review from a team and eseiler and removed request for a team February 8, 2021 10:39
@eseiler eseiler merged commit ea685e8 into seqan:master Feb 9, 2021
@marehr marehr deleted the concept_for_alignment branch February 17, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concepts for sequence and alignment
3 participants