Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce new seqan3::detail::transfer_type_modifier_onto #2365

Merged
merged 6 commits into from
Feb 3, 2021

Conversation

marehr
Copy link
Member

@marehr marehr commented Feb 2, 2021

This is needed to finish PR #2359 to workaround a nasty "bug" described in seqan/product_backlog#286.

@marehr marehr requested review from a team, Irallia and joergi-w and removed request for a team and Irallia February 2, 2021 10:58
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #2365 (8112d0e) into master (44ba173) will decrease coverage by 0.00%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2365      +/-   ##
==========================================
- Coverage   98.21%   98.21%   -0.01%     
==========================================
  Files         263      264       +1     
  Lines       10772    10784      +12     
==========================================
+ Hits        10580    10591      +11     
- Misses        192      193       +1     
Impacted Files Coverage Δ
include/seqan3/io/alignment_file/format_sam.hpp 96.33% <0.00%> (-1.80%) ⬇️
...de/seqan3/io/alignment_file/sam_tag_dictionary.hpp 100.00% <ø> (ø)
...nclude/seqan3/core/configuration/configuration.hpp 100.00% <100.00%> (ø)
include/seqan3/core/detail/debug_stream_byte.hpp 100.00% <100.00%> (ø)
...n3/search/dream_index/interleaved_bloom_filter.hpp 100.00% <100.00%> (ø)
include/seqan3/core/detail/debug_stream_type.hpp 76.92% <0.00%> (+15.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44ba173...6821bf0. Read the comment docs.

@joergi-w joergi-w requested review from a team and eseiler and removed request for a team February 2, 2021 15:36
@joergi-w
Copy link
Member

joergi-w commented Feb 2, 2021

In my opinion, this feature can become part of template_inspection.hpp, which contains already related functions (which I would love to see in stable (non-detail) API in the future in order to use them in my application).

Co-authored-by: Jörg Winkler <j.winkler@fu-berlin.de>
@marehr
Copy link
Member Author

marehr commented Feb 2, 2021

In my opinion, this feature can become part of template_inspection.hpp, which contains already related functions (which I would love to see in stable (non-detail) API in the future in order to use them in my application).

template_inspection.hpp contains only utility that works on template template things. So it doesn't really fit. We decided to make core NOAPI that means you can use it, but we don't guarantee that it will never break.

Copy link
Member

@eseiler eseiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

marehr and others added 2 commits February 3, 2021 13:40
Co-authored-by: Enrico Seiler <eseiler@users.noreply.github.com>
Co-authored-by: Enrico Seiler <eseiler@users.noreply.github.com>
@marehr marehr requested a review from eseiler February 3, 2021 12:42
@marehr marehr merged commit e7e0430 into seqan:master Feb 3, 2021
@marehr marehr deleted the transfer_type_modifier_onto branch February 3, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants