Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] rename seqan3::{alignment => sam}_file_header* #2411

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

marehr
Copy link
Member

@marehr marehr commented Feb 24, 2021

Part of many small rename PRs, tackles seqan/product_backlog#290.

@marehr marehr requested review from a team and simonsasse and removed request for a team February 24, 2021 15:45
@vercel
Copy link

vercel bot commented Feb 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/B3YwLj9qE26974pQGq7RgEHYjsUq
✅ Preview: https://seqan3-git-fork-marehr-samfile04-seqan.vercel.app

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #2411 (6411f19) into master (be6f2c1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2411      +/-   ##
==========================================
- Coverage   98.21%   98.21%   -0.01%     
==========================================
  Files         267      267              
  Lines       10864    10863       -1     
==========================================
- Hits        10670    10669       -1     
  Misses        194      194              
Impacted Files Coverage Δ
include/seqan3/io/alignment_file/format_bam.hpp 95.59% <ø> (ø)
include/seqan3/io/alignment_file/format_sam.hpp 96.33% <ø> (ø)
include/seqan3/io/alignment_file/input.hpp 100.00% <ø> (ø)
.../seqan3/io/alignment_file/input_format_concept.hpp 100.00% <ø> (ø)
...seqan3/io/alignment_file/output_format_concept.hpp 100.00% <ø> (ø)
include/seqan3/io/alignment_file/record.hpp 100.00% <ø> (ø)
include/seqan3/io/record.hpp 100.00% <ø> (ø)
include/seqan3/range/views/take.hpp 98.46% <ø> (ø)
...clude/seqan3/io/alignment_file/format_sam_base.hpp 98.74% <100.00%> (ø)
include/seqan3/io/alignment_file/header.hpp 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be6f2c1...a67c589. Read the comment docs.

Copy link
Member

@simonsasse simonsasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@eseiler eseiler requested review from eseiler and a team and removed request for eseiler and a team March 1, 2021 10:38
@eseiler eseiler merged commit 0fcd89a into seqan:master Mar 1, 2021
@marehr marehr deleted the sam_file04 branch March 1, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants