Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add changelog entry for #2458 #2495

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Mar 24, 2021

resolves #2455

@eseiler eseiler requested review from a team and Irallia and removed request for a team March 24, 2021 15:11
@vercel
Copy link

vercel bot commented Mar 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/Ac2cUjZ3NS38He9CWcmnsQLVoiEL
✅ Preview: https://seqan3-git-fork-eseiler-doc-changeloggz-seqan.vercel.app

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #2495 (6f27c2e) into master (7edeee5) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2495      +/-   ##
==========================================
+ Coverage   98.30%   98.31%   +0.01%     
==========================================
  Files         268      269       +1     
  Lines       11061    11134      +73     
==========================================
+ Hits        10873    10946      +73     
  Misses        188      188              
Impacted Files Coverage Δ
include/seqan3/alphabet/concept.hpp 100.00% <0.00%> (ø)
include/seqan3/alphabet/gap/gap.hpp 100.00% <0.00%> (ø)
include/seqan3/alphabet/alphabet_base.hpp 100.00% <0.00%> (ø)
include/seqan3/alphabet/aminoacid/aa20.hpp 100.00% <0.00%> (ø)
include/seqan3/alphabet/aminoacid/aa27.hpp 100.00% <0.00%> (ø)
include/seqan3/alphabet/structure/wuss.hpp 100.00% <0.00%> (ø)
include/seqan3/alphabet/nucleotide/dna4.hpp 100.00% <0.00%> (ø)
include/seqan3/alphabet/nucleotide/dna5.hpp 100.00% <0.00%> (ø)
include/seqan3/alphabet/nucleotide/rna4.hpp 100.00% <0.00%> (ø)
include/seqan3/alphabet/nucleotide/rna5.hpp 100.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7edeee5...6f27c2e. Read the comment docs.

Copy link
Contributor

@Irallia Irallia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM
However, I would use a colon when starting a bulleted list.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Lydia Buntrock <irallia@chrigelyra.de>
@Irallia Irallia requested review from a team and marehr and removed request for a team March 25, 2021 15:42
@eseiler eseiler linked an issue Mar 25, 2021 that may be closed by this pull request
@marehr marehr merged commit accc85b into seqan:master Mar 25, 2021
@eseiler eseiler deleted the doc/changelog_gz branch May 14, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gz output writes bgzf
3 participants