Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] sam record #2830

Merged
merged 3 commits into from
Sep 24, 2021
Merged

[TEST] sam record #2830

merged 3 commits into from
Sep 24, 2021

Conversation

marehr
Copy link
Member

@marehr marehr commented Sep 23, 2021

Several fixes to the sam record test.

  • Use ""_cigar literal
  • reference_id is normally a std::optional<int>
  • Add some comments to easier identify what the members are.

@marehr marehr requested review from a team and MitraDarja and removed request for a team September 23, 2021 19:50
@vercel
Copy link

vercel bot commented Sep 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/GBRcLJj1SGV4saiBCZLPXyN9dBSW
✅ Preview: https://seqan3-git-fork-marehr-samrecord-seqan.vercel.app

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #2830 (8dcc0a3) into master (c6decd3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2830   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files         277      277           
  Lines       10963    10963           
=======================================
  Hits        10785    10785           
  Misses        178      178           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6decd3...8dcc0a3. Read the comment docs.

@eseiler eseiler merged commit 8e45e8b into seqan:master Sep 24, 2021
@marehr marehr deleted the sam_record branch September 25, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants