-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INFRA] Drop gcc9 #2952
[INFRA] Drop gcc9 #2952
Changes from 1 commit
9076e34
9e6a48b
6b1042c
030a1f2
7e63848
c57dba8
64b90c9
bd80301
ef20871
7cb9e0a
f2734fa
322fb93
56405b1
17b6475
c5ccb4b
83db3ec
2bbdd92
cf0ddb8
93a478f
eb9290b
f7f55cf
d081e66
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -230,7 +230,7 @@ class inherited_iterator_base : public std::conditional_t<std::is_pointer_v<base | |
constexpr derived_t operator++(int) noexcept(noexcept(std::declval<base_t &>()++) && | ||
noexcept(derived_t(std::declval<base_t &>()))) | ||
//!\cond | ||
requires requires (base_t_ i) { i++; SEQAN3_RETURN_TYPE_CONSTRAINT(i++, std::same_as, base_t_); } && | ||
requires requires (base_t_ i) { i++; {i++} -> std::same_as<base_t_>; } && | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can't we leave the first i++ away? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe, but I wouldn't change the concept in this PR. |
||
std::constructible_from<derived_t, base_t_> | ||
//!\endcond | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks so much nicer now!