Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded micronaut to 4 #318

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

Conversation

munishchouhan
Copy link
Member

This PR will upgrade micronaut to 4

@munishchouhan munishchouhan linked an issue Oct 16, 2023 that may be closed by this pull request
@munishchouhan munishchouhan self-assigned this Oct 16, 2023
@munishchouhan
Copy link
Member Author

Getting this error:

11:35:38.638 [main] ERROR io.micronaut.runtime.Micronaut - Error starting Micronaut server: Bean definition [io.seqera.wave.Boostrap] could not be loaded: Error instantiating bean of type  [io.seqera.wave.Boostrap]

Message: Cannot invoke "java.util.Map.get(Object)" because "this.registries" is null
Path Taken: new Boostrap()
io.micronaut.context.exceptions.BeanInstantiationException: Bean definition [io.seqera.wave.Boostrap] could not be loaded: Error instantiating bean of type  [io.seqera.wave.Boostrap]

Message: Cannot invoke "java.util.Map.get(Object)" because "this.registries" is null
Path Taken: new Boostrap()
	at io.micronaut.context.DefaultBeanContext.initializeContext(DefaultBeanContext.java:1979)
	at io.micronaut.context.DefaultApplicationContext.initializeContext(DefaultApplicationContext.java:290)
	at io.micronaut.context.DefaultBeanContext.readAllBeanDefinitionClasses(DefaultBeanContext.java:3337)
	at io.micronaut.context.DefaultBeanContext.finalizeConfiguration(DefaultBeanContext.java:3690)
	at io.micronaut.context.DefaultBeanContext.start(DefaultBeanContext.java:345)
	at io.micronaut.context.DefaultApplicationContext.start(DefaultApplicationContext.java:198)
	at io.micronaut.runtime.Micronaut.start(Micronaut.java:73)
	at io.seqera.wave.Application.main(Application.groovy:41)
Caused by: io.micronaut.context.exceptions.BeanInstantiationException: Error instantiating bean of type  [io.seqera.wave.Boostrap]

Message: Cannot invoke "java.util.Map.get(Object)" because "this.registries" is null
Path Taken: new Boostrap()
	at io.micronaut.context.DefaultBeanContext.resolveByBeanFactory(DefaultBeanContext.java:2322)
	at io.micronaut.context.DefaultBeanContext.doCreateBean(DefaultBeanContext.java:2277)
	at io.micronaut.context.DefaultBeanContext.doCreateBean(DefaultBeanContext.java:2289)
	at io.micronaut.context.DefaultBeanContext.createRegistration(DefaultBeanContext.java:3056)
	at io.micronaut.context.SingletonScope.getOrCreate(SingletonScope.java:81)
	at io.micronaut.context.DefaultBeanContext.findOrCreateSingletonBeanRegistration(DefaultBeanContext.java:2958)
	at io.micronaut.context.DefaultBeanContext.initializeEagerBean(DefaultBeanContext.java:2676)
	at io.micronaut.context.DefaultBeanContext.initializeContext(DefaultBeanContext.java:1973)
	... 7 common frames omitted
Caused by: java.lang.NullPointerException: Cannot invoke "java.util.Map.get(Object)" because "this.registries" is null
	at io.seqera.wave.auth.RegistryConfig.getRegistryKeys(RegistryConfig.groovy:51)
	at io.seqera.wave.auth.RegistryCredentialsProviderImpl.getDefaultCredentials0(RegistryCredentialsProviderImpl.groovy:82)
	at io.seqera.wave.auth.RegistryCredentialsProviderImpl.getDefaultCredentials(RegistryCredentialsProviderImpl.groovy:71)
	at io.seqera.wave.Boostrap.init(Boostrap.groovy:44)
	at io.seqera.wave.$Boostrap$Definition.initialize(Unknown Source)
	at io.seqera.wave.$Boostrap$Definition.instantiate(Unknown Source)
	at io.micronaut.context.DefaultBeanContext.resolveByBeanFactory(DefaultBeanContext.java:2307)
	... 14 common frames omitted

@munishchouhan munishchouhan marked this pull request as draft October 18, 2023 10:32
@munishchouhan
Copy link
Member Author

munishchouhan commented Oct 30, 2023

Issue raised with Micornaut team about unit tests not working as exxpected
micronaut-projects/micronaut-core#10051

@marcodelapierre
Copy link
Member

@munishchouhan can you review the suggestion in micronaut-projects/micronaut-core#10051,
to see if it could help for this PR? - thank you

@munishchouhan
Copy link
Member Author

@marcodelapierre it is blocked by seqeralabs/libseqera#7

@marcodelapierre
Copy link
Member

marcodelapierre commented Nov 17, 2023

I see, thanks Munish.

@pditommaso on Monday let's discuss prioritising the upgrade of Nextflow to Groovy 4

@munishchouhan
Copy link
Member Author

getting error, while running tests


Cannot create mock for class io.seqera.wave.service.aws.AwsEcrService . Mocking of non-interface types requires a code generation library. Please put an up-to-date version of byte-buddy or cglib-nodep on the class path.
org.spockframework.mock.CannotCreateMockException: Cannot create mock for class io.seqera.wave.service.aws.AwsEcrService . Mocking of non-interface types requires a code generation library. Please put an up-to-date version of byte-buddy or cglib-nodep on the class path.
	at org.spockframework.mock.runtime.ProxyBasedMockFactory.create(ProxyBasedMockFactory.java:47)
	at org.spockframework.mock.runtime.JavaMockFactory.createInternal(JavaMockFactory.java:58)
	at org.spockframework.mock.runtime.JavaMockFactory.create(JavaMockFactory.java:38)
	at org.spockframework.mock.runtime.CompositeMockFactory.create(CompositeMockFactory.java:44)
	at org.spockframework.lang.SpecInternals.createMock(SpecInternals.java:50)
	at org.spockframework.lang.SpecInternals.createMockImpl(SpecInternals.java:305)
	at org.spockframework.lang.SpecInternals.createMockImpl(SpecInternals.java:295)
	at org.spockframework.lang.SpecInternals.MockImpl(SpecInternals.java:104)
	at io.seqera.wave.auth.RegistryCredentialsProviderTest.should get credentials from user(RegistryCredentialsProviderTest.groovy:111)

munishchouhan and others added 2 commits May 28, 2024 11:51
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso
Copy link
Contributor

@munishchouhan can you please have a look at this conflict? ☝️

@munishchouhan
Copy link
Member Author

@munishchouhan can you please have a look at this conflict? ☝️

sure

@pditommaso pditommaso marked this pull request as ready for review June 5, 2024 13:48
@pditommaso
Copy link
Contributor

Managed to upgrade libseqera deps, but many tests still fails. Not sure that's because I've also upgraded to MN 4.4.3 from 4.1.6

@munishchouhan
Copy link
Member Author

Managed to upgrade libseqera deps, but many tests still fails. Not sure that's because I've also upgraded to MN 4.4.3 from 4.1.6

ok sure, I will fix them

@munishchouhan
Copy link
Member Author

Error using wave:

% wave -i ubuntu --wave-endpoint http://localhost:9090
aa0ca0c91267.ngrok.app/wt/f948f4f98162/library/ubuntu:latest

% docker pull  aa0ca0c91267.ngrok.app/wt/f948f4f98162/library/ubuntu:latest
latest: Pulling from wt/f948f4f98162/library/ubuntu
aa21f24e1940: Verifying Checksum
error pulling image configuration: image config verification failed for digest sha256:28bc33afd4c9a541270cdae3de1f78190908ffb34081e40e636fb7fec32434e3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Micronaut 4.1
3 participants