Model association for sequalize-cli 4.0.0 updates #620
Conversation
buddylindsey
changed the title
|
@sushantdhiman I think the tests will pass if they can just be restarted. Looks like one got hung up for a very long time. Are you able to restart the build? I don't see a button to do it so I don't think I have permissions. If not I can try to find something to push to kick off another build. |
|
No problem, I will retry that test |
| @@ -197,7 +197,7 @@ const _ = require('lodash'); | |||
|
|
|||
| const targetContent = attrUnd.underscored ? | |||
| 'underscored: true' | |||
| : '{\n classMethods'; | |||
| : '{});'; | |||
There was a problem hiding this comment.
Sorry for being a bit dense. I am not sure what you are wanting.
There was a problem hiding this comment.
We need to check if generated model contain associate method, just scanning file with .associate around here should be enough
Just add .pipe(helpers.ensureContent('.associate'))
There was a problem hiding this comment.
Okay. Will do.
test/model/create.test.js
Outdated
| @@ -210,7 +210,8 @@ const _ = require('lodash'); | |||
| .src(Support.resolveSupportPath('tmp', 'models')) | |||
| .pipe(helpers.readFile('user.js')) | |||
| .pipe(helpers.ensureContent(targetContent)) | |||
| .pipe(helpers.teardown(done)); | |||
| .pipe(helpers.teardown(done)) | |||
| .pipe(helpers.ensureContent('.associate')); | |||
There was a problem hiding this comment.
.pipe(helpers.ensureContent('.associate')), Should come before teardown, I think tests will fail
There was a problem hiding this comment.
hah. okay, they passed locally. Will move it. Totally didn't realize those where teardowns.
buddylindsey
force-pushed
the
model-association
branch
from
26b6608
to
ba94a1c
Compare
|
@sushantdhiman okay. I moved the line up above teardown and force pushed a rebase to keep the commit history a bit cleaner. |
|
@sushantdhiman looks like we are good to go. It is now mergeable and the tests have all passed. |
Created this to deal with a merge conflict so it can be merged. Preserved commits for contribution credit.