Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make CI pipeline run v7 on Node.js >= 16 #262

Closed
wants to merge 1 commit into from
Closed

fix: make CI pipeline run v7 on Node.js >= 16 #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ jobs:
fail-fast: false
matrix:
# node 10 is the minimum supported version for Sequelize 6
# node 14 is the minimum supported version for Sequelize 7
# node 16 is latest LTS (to keep updated)
# node 16 is the minimum supported version for Sequelize 7
# node 18 is latest LTS (to keep updated)
node: [10, 14, 16]
name: SQLite (sequelize 6 & 7, node ${{ matrix.node }})
runs-on: ubuntu-latest
Expand All @@ -23,7 +23,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 14.x
node-version: ${{ matrix.node }}
- run: /bin/bash ./setup/prepare-ci.sh
- name: Execute SSCCE
run: npm run _test
Expand Down
2 changes: 1 addition & 1 deletion setup/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ async function wrappedRun() {
logBlue(heading);
logBlue(`${'-'.repeat(heading.length)}\n`);

if (majorNodeVersion >= 14) {
if (majorNodeVersion >= 16) {
const { run, testingOnDialects } = require('../src/sscce-sequelize-7');
if (!testingOnDialects.has(process.env.DIALECT!)) {
logRed(`Skipping dialect ${process.env.DIALECT} as it has been omitted from 'testingOnDialects'`);
Expand Down