Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseInt option for Queries - parseFloat missing? #579

Closed
mweibel opened this issue May 1, 2013 · 4 comments
Closed

parseInt option for Queries - parseFloat missing? #579

mweibel opened this issue May 1, 2013 · 4 comments
Assignees

Comments

@mweibel
Copy link
Contributor

mweibel commented May 1, 2013

Hi,

we're currently implementing the function sum() for sequelize and ran across this line, dao factory#271.
In my opinion, this should rather be parseFloat and the respective options-parser in query-interface#295 should also check this option and do rather a parseFloat.

Do you know why you didn't add support this or is this just a missing functionality?

  • Michael
@ghost ghost assigned janmeier May 2, 2013
@janmeier
Copy link
Member

janmeier commented May 2, 2013

Agree, no reason this shouldn't be parseFloat

@durango
Copy link
Member

durango commented May 2, 2013

I'll take care of this writing tests now

@ghost ghost assigned durango May 2, 2013
@durango durango closed this as completed in 92bb5fe May 2, 2013
durango added a commit that referenced this issue May 2, 2013
Min/Max decimal support closes #579
@durango
Copy link
Member

durango commented May 2, 2013

@mweibel #583

I just pushed the update to fix this, if you immediately need it grab it from the Repo :)

@mweibel
Copy link
Contributor Author

mweibel commented May 3, 2013

Thanks!

Am 02.05.2013 um 20:59 schrieb durango notifications@github.com:

@mweibel #583

I just pushed the update to fix this, if you immediately need it grab it from the Repo :)


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants