chore(deps): update dependency expect-type to v0.13.0

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
expect-type	0.12.0 -> 0.13.0

---

Release Notes

mmkal/ts

v0.13.0

minor changes

• Fix constructor parameter comparison (#​245)

---

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by WhiteSource Renovate. View repository job log here.

[WikiRik]

@ephys could you maybe take a look at this in the coming week or so?

[ephys]

I've tried but I can't manage to make the typing tests for the mutability of hooks options work in TS [4.2,4.4] :/

[WikiRik]

Do you think it's a bug with expect-type or with our typings?

[ephys]

I managed to narrow the issue down to NoReadonlyArraysDeep.
The error was also present in my temporary test that did not use expect-type, so it's more likely that expect-type wasn't reporting an existing issue before.

Since the test passes starting with TS 4.5, I think our code might be correct. It might be a limitation of TS < 4.5. Not sure why it works in TS 4.1.

I'm pretty sure TS < 4.5 does not like us mapping the entries of an array.

Looked into whether other libraries had implemented this, such as type-fest but did not find anything.

I was still sick when I looked into this, we could look for more implementations of a DeepMutable type and see if it's done differently.

[ephys]

I think I figured it out.

The test was making sure the whole options bag was mutable

The option bags that were failing all accepted where: WhereOptions

A lot of pieces in WhereOptions accept readonly arrays

I've removed the readonly arrays as a first draft and it works.

The thing is, these readonly arrays were added for a reason:

But the test to ensure they're writable was also added for a reason:

We have two concepts at odds with eachother:

• One wants to have the whole options bag mutable to modify it in the hooks
• The other wants to be able to use readonly arrays.

We're going to have to displease one or the other. We won't be able to please everyone and we'll need to choose which user is going to be wrong.

Proposition : we check for mutability up to the where option. i.e. it can be replaced in hooks, but not mutated

Don't merge yet!

[WikiRik]

I think I like that proposition, shall we add that in a separate PR and then merge this update afterwards?

[ephys]

I'll reset this PR and do it here, so we can make sure the typing tests are passing :)

[WikiRik]

@ephys did you fix this issue when working on the WhereOptions typing? Or is this something to keep in mind for #14020 ?

[ephys]

That PR didn't fix it
It's only blocking for #14091 but that PR is also blocked by #14302, so this PR hasn't been a priority for me

Let's reset this PR though

[WikiRik]

It seems to work now in 4.4 so I guess we can merge this

[ephys]

That could mean I broke something in #14368
But might as well merge this and fix both the test and the issue in a follow-up PR if something arises

[github-actions]

🎉 This PR is included in version 7.0.0-alpha.11 🎉

The release is available on:

• npm package (@release-v7 dist-tag)
• GitHub release

Your semantic-release bot 📦🚀