Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export data types under DataTypes namespace #6438

Merged
merged 1 commit into from
Aug 15, 2016

Conversation

felixfbecker
Copy link
Contributor

Closes #6435

@janmeier janmeier merged commit 23f1316 into sequelize:master Aug 15, 2016
@felixfbecker felixfbecker deleted the export-data-types branch August 15, 2016 10:50
felixfbecker added a commit to types/sequelize that referenced this pull request Aug 15, 2016
@adamjaffeback
Copy link

Thanks @felixfbecker, this PR looks just like what I was looking for, but I notice it didn't get included in the most recent release (3.24.2). Could that be because one set of CI failed-out due to a coveralls issue?

On the failure subsuite, looks like all the tests passed:
image

But coveralls failed to provide a timely response:
image

Could either of you try retriggering the build? I fear it's out-of-date at this point and won't pass, but it's a great, simple addition.

@felixfbecker
Copy link
Contributor Author

This PR was made to the master branch, which is the development for v4. Feel free to backport it to v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants