Skip to content

Backport data types under DataTypes namespace to v3.#6578

Merged
janmeier merged 1 commit intosequelize:v3from
adamjaffeback:feat/DataTypes
Sep 12, 2016
Merged

Backport data types under DataTypes namespace to v3.#6578
janmeier merged 1 commit intosequelize:v3from
adamjaffeback:feat/DataTypes

Conversation

@adamjaffeback
Copy link
Copy Markdown

Addresses #6435 in v3, as discussed in PR #6438. Also, totally messed up #6577, which is essentially the same PR, but this one is rebased appropriately.

Pull Request check-list

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does your issue contain a link to existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Have you added an entry under Future in the changelog?
    • Not sure about how the Future log works. Should that only be used for v4?
  • Have you added new tests to prevent regressions?
    • Not sure if this needs tests. If could add something to check if DataTypes exists on the Sequelize prototype, but there is no precedent for this, such as with Validator or Transaction.

Description of change

Currently, DataTypes are accessed on the Sequelize object by using the type's name: Sequelize.INTEGER.

This change additionally adds data types under the DataTypes namespace: Sequelize.DataTypes.INTEGER

@felixfbecker
Copy link
Copy Markdown
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants