New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport data types under DataTypes namespace to v3. #6578

Merged
merged 1 commit into from Sep 12, 2016

Conversation

3 participants
@adamjaffeback
Contributor

adamjaffeback commented Sep 9, 2016

Addresses #6435 in v3, as discussed in PR #6438. Also, totally messed up #6577, which is essentially the same PR, but this one is rebased appropriately.

Pull Request check-list

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does your issue contain a link to existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Have you added an entry under Future in the changelog?
    • Not sure about how the Future log works. Should that only be used for v4?
  • Have you added new tests to prevent regressions?
    • Not sure if this needs tests. If could add something to check if DataTypes exists on the Sequelize prototype, but there is no precedent for this, such as with Validator or Transaction.

Description of change

Currently, DataTypes are accessed on the Sequelize object by using the type's name: Sequelize.INTEGER.

This change additionally adds data types under the DataTypes namespace: Sequelize.DataTypes.INTEGER

@felixfbecker

This comment has been minimized.

Contributor

felixfbecker commented Sep 10, 2016

LGTM

@janmeier janmeier merged commit f228e1f into sequelize:v3 Sep 12, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment