Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactions for SQL Server - V3 backport #7001

Merged
merged 3 commits into from
Dec 21, 2016

Conversation

harshithkashyap
Copy link

@harshithkashyap harshithkashyap commented Dec 17, 2016

Pull Request check-list

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does your issue contain a link to existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Have you added an entry under Future in the changelog?

Description of change

V3 backport for #6972

@mention-bot
Copy link

@harshithkashyap, thanks for your PR! By analyzing the history of the files in this pull request, we identified @BridgeAR, @mbroadst and @janmeier to be potential reviewers.

@harshithkashyap harshithkashyap force-pushed the mssql-tran-fix-v3 branch 2 times, most recently from e2ca9ce to 78413fd Compare December 17, 2016 20:00
@codecov-io
Copy link

codecov-io commented Dec 17, 2016

Current coverage is 93.97% (diff: 93.33%)

Merging #7001 into v3 will increase coverage by 0.08%

Powered by Codecov. Last update cb6c493...3dc9b1b

@harshithkashyap
Copy link
Author

@felixfbecker @janmeier Any changes in this backport?

@felixfbecker
Copy link
Contributor

Are there any changes in the backport besides from the original PR?

@harshithkashyap
Copy link
Author

No, they are same except for the ES5 syntax.

@janmeier janmeier merged commit 547897d into sequelize:v3 Dec 21, 2016
@janmeier
Copy link
Member

👍

@harshithkashyap harshithkashyap deleted the mssql-tran-fix-v3 branch December 21, 2016 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants