Transactions for SQL Server by harshithkashyap · Pull Request #6972 · sequelize/sequelize

harshithkashyap · 2016-12-10T11:09:58Z

Pull Request check-list

Does npm run test or npm run test-DIALECT pass with this change (including linting)?
Does your issue contain a link to existing issue (Closes #[issue]) or a description of the issue you are solving?
Have you added new tests to prevent regressions?
Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
Have you added an entry under Future in the changelog?

Description of change

Based on @mbroadst suggestion, generateTransactionId method is added which uses crypto.randomBytes and uuid.v4 in case of other dialects. Closes Transaction name too long for MSSQL #3950
Enabled tests for transactions for mssql dialect
Added SAVE TRANSACTION check to call tedious.saveTransaction method
Fix tests which are skipped

mention-bot · 2016-12-10T11:10:00Z

@harshithkashyap, thanks for your PR! By analyzing the history of the files in this pull request, we identified @BridgeAR, @felixfbecker and @mbroadst to be potential reviewers.

harshithkashyap · 2016-12-10T11:14:33Z

@felixfbecker @janmeier I've skipped a lot of tests which were timing out. By default, SQL Server blocks even select calls if the row has an exclusive lock. Most of the tests in the codebase fails as transaction is never committed/rolledback.

How do you guys prefer to fix this? I'm checking if the dialect is mssql and using Promise.resolve to skip the select statement in some tests. There are a lot of tests based on this approach as Postgresql and Mysql only blocks writes and allows reads.

codecov-io · 2016-12-10T11:18:16Z

Current coverage is 94.80% (diff: 95.45%)

No coverage report found for master at cc09a3c.

Powered by Codecov. Last update cc09a3c...28fce11

felixfbecker · 2016-12-10T11:40:41Z

Well cheating the tests is not an option of course. Maybe just commit the transaction before the SELECT?

harshithkashyap · 2016-12-10T11:43:40Z

But would that not cause the subsequent then calls to fail as it tries to use a transaction which is already committed?

harshithkashyap · 2016-12-11T07:22:07Z

@mickhansen @sushantdhiman Suggestions?

…dentifier, enabled trasaction tests for mssql dialect

…s, transaction savepoints, uses sequelize_test as default database on appveyor

harshithkashyap · 2016-12-17T17:52:35Z

@felixfbecker @janmeier SQL Server allows READ_COMMITTED_SNAPSHOT option to allow reads during transactions. I've enabled back all the tests and all of the pass in my localhost.
READ_COMMITTED_SNAPSHOT must be turned on before we can use it and it cannot be enabled on master database. I've changed the database in appveyor-setup.ps1 to sequelize_test but i think it has to be manually created on your end. Could you guys please enable it and review this PR?

felixfbecker · 2016-12-17T17:55:46Z

@harshithkashyap What do you mean with "it has to be enabled on our end"? AppVeyor is 100% configured through appveyor.yml and appveyor-setup.ps1

harshithkashyap · 2016-12-17T18:01:29Z

I've changed the database from master to sequelize_test here. I expected appveyor to create the sequelize_test database automatically with the credentials from appveyor-setup.ps1 file.
Login failed error is thrown in the build.

…alect

felixfbecker · 2016-12-17T19:13:11Z

hm no idea, im no mssql expert

harshithkashyap · 2016-12-17T19:18:57Z

@felixfbecker I've fixed it using appveyor-setup.ps1 script

harshithkashyap · 2016-12-20T05:58:00Z

@janmeier @sushantdhiman @felixfbecker Request review!

janmeier

LGTM, good work

Out of curiousity, did you figure out why we have to call the beginTransaction et.al. methods, instead of just sending the sql command?

felixfbecker · 2016-12-20T10:43:16Z

lib/dialects/mssql/query.js

+        }, this.options.transaction.name);
+      } else if (_.includes(this.sql, 'SAVE TRANSACTION')) {
+        connection.saveTransaction(err => {
+          if (!!err) {


unneeded boolean cast

@felixfbecker beginTransaction, rollbackTransaction and commitTransaction also has boolean cast. Should i remove them aswell?

Feel free to do so. The desired coding style is defined in eslintrc.json, it's just that the codebase does not fully comply with it yet.

felixfbecker · 2016-12-20T10:43:33Z

lib/query-interface.js

      transaction: transaction.parent || transaction
    });
-
+    options.transaction.name = transaction.parent ? transaction.name: undefined;


space before colon

felixfbecker · 2016-12-20T10:43:40Z

lib/query-interface.js

      supportsSearchPath: false
    });
-
+    options.transaction.name = transaction.parent ? transaction.name: undefined;


space before colon

harshithkashyap · 2016-12-20T16:42:34Z

@janmeier Without tedious methods, sql server throws

Transaction count after EXECUTE indicates a mismatching number of BEGIN and COMMIT statements. Previous count = 0, current count = 1.

We use connection.execSql(request); here. When beginTransaction and other methods are called, tedious internally calls connection.execSqlBatch instead of connection.execSql.

Using connection.execSqlBatch allows us to execute sequelize generated queries. All tests seems to pass aswell.

From the tedious docs, it seems that SQL Server will not reuse the execution plan if the same queries are executed again and again. This might add overhead to non transaction queries.

…ize#6954

felixfbecker · 2016-12-20T17:38:19Z

test/config/config.js

    host:     process.env.SEQ_MSSQL_HOST || process.env.SEQ_HOST || 'mssql.sequelizejs.com',
    port:     process.env.SEQ_MSSQL_PORT || process.env.SEQ_PORT || 1433,
    dialectOptions: {
-      instanceName:  process.env.MSSQL_INSTANCE ? process.env.MSSQL_INSTANCE : 'SQLEXPRESS',


Why is this not needed anymore?

By default instance names are unnamed. I cannot connect to my local server even after specifying the server name and port. And it doesn't default to SQLEXPRESS

Okay, was just curious. I'm not familiar with MSSQL, I just ported the thing over to AppVeyor and copied a lot from tedious PowerShell setup script.

janmeier · 2016-12-21T12:57:50Z

Good work @harshithkashyap ! :)

harshithkashyap force-pushed the mssql-tran-name-fix branch from 95c4706 to 59685a0 Compare December 10, 2016 11:21

harshithkashyap changed the title ~~Trasactions for SQL Server~~ Transactions for SQL Server Dec 10, 2016

harshithkashyap added 2 commits December 17, 2016 22:53

[MSSQL] Uses crypto randomBytes to generate 20 character trasaction i…

9536f76

…dentifier, enabled trasaction tests for mssql dialect

Added missing break, changelog entry

cd60051

harshithkashyap force-pushed the mssql-tran-name-fix branch 2 times, most recently from 8317577 to aea2138 Compare December 17, 2016 17:29

Added READ_COMMITTED_SNAPSHOT ON script for tests, fixes skipped test…

b759355

…s, transaction savepoints, uses sequelize_test as default database on appveyor

harshithkashyap force-pushed the mssql-tran-name-fix branch from aea2138 to b759355 Compare December 17, 2016 17:45

Added sqlcmd database query to appveyor-setup.ps1

8c10a10

harshithkashyap force-pushed the mssql-tran-name-fix branch from 762b742 to 8c10a10 Compare December 17, 2016 18:29

harshithkashyap added 2 commits December 18, 2016 00:14

Added sequelize_test as default db in test/config/config for MSSQL di…

3e4116e

…alect

Moved READ_COMMITTED_SNAPSHOT ON query to appveyor ps script

cd4d219

harshithkashyap mentioned this pull request Dec 17, 2016

Transactions for SQL Server - V3 backport #7001

Merged

5 tasks

felixfbecker requested review from janmeier, mickhansen and sushantdhiman December 20, 2016 10:42

janmeier approved these changes Dec 20, 2016

View reviewed changes

felixfbecker suggested changes Dec 20, 2016

View reviewed changes

Replaced lodash includes with startsWith, review fixes, closes sequel…

28fce11

…ize#6954

felixfbecker reviewed Dec 20, 2016

View reviewed changes

felixfbecker approved these changes Dec 20, 2016

View reviewed changes

felixfbecker added the pr:final review label Dec 20, 2016

janmeier merged commit 086255e into sequelize:master Dec 21, 2016

janmeier mentioned this pull request Dec 21, 2016

fix for bug: Transaction name too long for MSSQL #3950 #5959

Closed

5 tasks

harshithkashyap deleted the mssql-tran-name-fix branch December 21, 2016 16:20

mokkabonna mentioned this pull request Oct 2, 2017

Add saveTransaction ratanakvlun/sequelize-msnodesqlv8#9

Merged

Uh oh!

Conversation

harshithkashyap commented Dec 10, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request check-list

Description of change

Uh oh!

mention-bot commented Dec 10, 2016

Uh oh!

harshithkashyap commented Dec 10, 2016

Uh oh!

codecov-io commented Dec 10, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 94.80% (diff: 95.45%)

Uh oh!

felixfbecker commented Dec 10, 2016

Uh oh!

harshithkashyap commented Dec 10, 2016

Uh oh!

harshithkashyap commented Dec 11, 2016

Uh oh!

harshithkashyap commented Dec 17, 2016

Uh oh!

felixfbecker commented Dec 17, 2016

Uh oh!

harshithkashyap commented Dec 17, 2016

Uh oh!

felixfbecker commented Dec 17, 2016

Uh oh!

harshithkashyap commented Dec 17, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

harshithkashyap commented Dec 20, 2016

Uh oh!

janmeier left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

harshithkashyap commented Dec 20, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

janmeier commented Dec 21, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

harshithkashyap commented Dec 10, 2016 •

edited

Loading

codecov-io commented Dec 10, 2016 •

edited

Loading

harshithkashyap commented Dec 17, 2016 •

edited

Loading