Closes #723 (consistent handling of limit and offset across dialects) #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the jasmine tests :) |
|
Woops, stupid me. We really need to migrate away from jasmine soon so I don't forget to run half the tests :D |
|
Any update on this? |
|
Will fix it later today or over the weekend :) |
|
Done @durango |
durango
added a commit
that referenced
this pull request
Jun 28, 2013
Closes #723 (consistent handling of limit and offset across dialects)
|
Thanks! And ty for including the changelog.md changes, I'll try to keep that in mind for my future PRs ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @iamJochen in #533, there was a discrepancy in how limit and offset were handled across different dialects.
If not limit is given, MySQL and SQLite will set the limit to max table size (1.844E+19 and 1e+13 respectively)