New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #723 (consistent handling of limit and offset across dialects) #725

Merged
merged 4 commits into from Jun 28, 2013

Conversation

2 participants
@janmeier
Member

janmeier commented Jun 24, 2013

As noted by @iamjochen in #533, there was a discrepancy in how limit and offset were handled across different dialects.

If not limit is given, MySQL and SQLite will set the limit to max table size (1.844E+19 and 1e+13 respectively)

janmeier added some commits Jun 24, 2013

@durango

This comment has been minimized.

Member

durango commented Jun 24, 2013

Please update the jasmine tests :)

@janmeier

This comment has been minimized.

Member

janmeier commented Jun 25, 2013

Woops, stupid me. We really need to migrate away from jasmine soon so I don't forget to run half the tests :D

@durango

This comment has been minimized.

Member

durango commented Jun 28, 2013

Any update on this?

@janmeier

This comment has been minimized.

Member

janmeier commented Jun 28, 2013

Will fix it later today or over the weekend :)

@janmeier

This comment has been minimized.

Member

janmeier commented Jun 28, 2013

Done @durango

durango added a commit that referenced this pull request Jun 28, 2013

Merge pull request #725 from janmeier/limitoffset
Closes #723 (consistent handling of limit and offset across dialects)

@durango durango merged commit 366685e into sequelize:master Jun 28, 2013

1 check passed

default The Travis CI build passed
Details
@durango

This comment has been minimized.

Member

durango commented Jun 28, 2013

Thanks! And ty for including the changelog.md changes, I'll try to keep that in mind for my future PRs ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment