V3 backport: Fixes QueryInterface#changeColumn for enums#7456
Merged
sushantdhiman merged 3 commits intosequelize:v3from Apr 19, 2017
Merged
V3 backport: Fixes QueryInterface#changeColumn for enums#7456sushantdhiman merged 3 commits intosequelize:v3from
sushantdhiman merged 3 commits intosequelize:v3from
Conversation
|
@seshness, thanks for your PR! By analyzing the history of the files in this pull request, we identified @overlookmotel, @jonathana and @durango to be potential reviewers. |
Contributor
|
@seshness Needs a changelog entry [FIXED] `changeColumn` generates incorrect query with ENUM type [#7456](https://github.com/sequelize/sequelize/pull/7456) |
Fixes QueryInterface#changeColumn for enums
ae1cb23 to
4831558
Compare
sushantdhiman
approved these changes
Apr 19, 2017
holm
pushed a commit
to holm/sequelize
that referenced
this pull request
Nov 13, 2017
) * Backport sequelize#7455 Fixes QueryInterface#changeColumn for enums * Prevent test from running in MSSQL * Adds a changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
npm run testornpm run test-DIALECTpass with this change (including linting)?Futurein the changelog?Description of change
Previous changes to support schemas in QueryInterface generated invalid Postgres SQL when attempting to change a column to an enum value.
Instead of generating
with this change we will now generate