New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom primary key (not keys, just singular) should no longer be a problem for models when using any of the data retrievals with just a number or through associations. Closes #694 #771

Merged
merged 16 commits into from Aug 9, 2013

Conversation

5 participants
@durango
Member

durango commented Jul 16, 2013

Yeah kind of a lot... :P

durango added some commits Jul 16, 2013

Custom primary key (not keys, just singular) should no longer be a pr…
…oblem for models when using any of the data retrievals with just a number or through associations. Closes #694
@ostera

This comment has been minimized.

ostera commented Jul 27, 2013

👍

@sdepold

This comment has been minimized.

Member

sdepold commented Aug 4, 2013

can u rebase ?

@sdepold

This comment has been minimized.

Fixed up one off connection clients for Sequelize (if client is alrea…
…dy defined simply callback rather than connecting again).

durango added a commit that referenced this pull request Aug 9, 2013

Merge pull request #771 from durango/association-key
Custom primary key (not keys, just singular) should no longer be a problem for models when using any of the data retrievals with just a number or through associations. Closes #694

@durango durango merged commit 99d02bd into sequelize:master Aug 9, 2013

1 check passed

default The Travis CI build passed
Details

@durango durango deleted the durango:association-key branch Aug 9, 2013

@coveralls

This comment has been minimized.

coveralls commented Oct 2, 2014

Coverage Status

Changes Unknown when pulling 059bab9 on durango:association-key into * on sequelize:master*.

@mickhansen

This comment has been minimized.

Contributor

mickhansen commented Oct 3, 2014

What are you doing @coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment