Closes sequelize/sequelize#9608. Added dialectModule parameter.

[catamphetamine]

Added dialectModule parameter for Webpack.
Closes #9608

[codecov]

Codecov Report

Merging #9609 into master will decrease coverage by 0.03%.
The diff coverage is 50%.

[sushantdhiman]

Going to need some integration test for this, for all dialects

1. Create a new test file dialect-module-configuration.test.js https://github.com/sequelize/sequelize/tree/master/test/integration/
2. Test that both dialectModule and dialectModulePath works.
   1. dialectModule can be tested by first requiring module in your test, adding some dummy property to library module and then asserting sequelize.connectionManager.lib also got same property after initializing with custom module
   2. dialectModulePath can be tested simply by asserting if new Sequelize works without throwing MODULE NOT FOUND error

[catamphetamine]

@sushantdhiman
I agree that tests are required for such a widely used library.
Added some stubs for tests for now.
Other people can possibly join too.

[sushantdhiman]

Please let me know whenever you are willing to continue on this, I will reopen this.

Also there are actually very slim chances that someone will help you write those tests, if you need this feature I am afraid you will need to work on them yourself.

[yvele]

@catamphetamine what can I do to help with this?

[catamphetamine]

@yvele Don't ask me, ask the author of the library: he doesn't want to merge it in.

[sushantdhiman]

@catamphetamine ah, blaming me for something I never did :)

As I said earlier #9609 (comment) I need proper tests before merging this. I can't merge something untested just like that

[yvele]

How can I help? @catamphetamine you need to give me access to https://github.com/catamphetamine/sequelize I think 🤔

@sushantdhiman This issue is important to fix because I can't understand why sequelize is doing the require, it should be more simple and explicitly take the whole module (better for mocking, etc.)

[papb]

Related: #13169