-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tutorial Major issue] BBPSSW Protocol in Tutorial Chapter 3 Seems Wrong #171
Comments
Hi Caitao, Thanks for pointing this out. You are indeed correct in noting that the state should be properly initialized to the Werner state before running the protocol. The tutorial code was written for an older version of the source code that explicitly calculated the success probability using the fidelity, but this has since been changed. I started a branch linked to this issue to fix this, and it looks like the example2.py code is running properly there. I will continue to fix the rest of the code/update the documentation. Thanks, |
Hi Alex, Thanks for the clarification on For
That is because the following function sets the initial state in
It is easy to fix, just add the following to the function:
Thanks, |
Hi SeQUeNCe team,
I tried tutorial/chapter3/example2.py about entanglement purification BBPSSW protocol. The outcome of the program is very confusing to me and doesn't seem correct. What is wrong is that when running example2.py, the purification is always successful, which in theory shouldn't be (The tutorial itself also says there are two possible outcomes, success or failure).
By looking into the code, what I figured wrong is that the initial state is not prepared correctly. According to BBPSSW protocol, the initial state should be a Werner State. But the tutorial prepared the initial state as |0>.
Moreover, tests/entanglement_management/test_purification.py also didn't prepare the initial state in Werner State, instead, it prepared in pure Bell States.
I think preparing the initial state of the system is a crucial step of the protocol and needs to be fixed.
Also, tutorial/chapter3/example3.py about entanglement swapping also incorrectly prepared the initial state of the system. The system should be prepared in an entangled Bell State such as phi_plus. But the system is prepared in an unentangled state of |0>
Thank you for your time,
Caitao
The text was updated successfully, but these errors were encountered: