Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code quality #2

Closed
reverofevil opened this issue Apr 13, 2017 · 1 comment
Closed

Code quality #2

reverofevil opened this issue Apr 13, 2017 · 1 comment

Comments

@reverofevil
Copy link

reverofevil commented Apr 13, 2017 •
edited
Loading

Only one type of packets is supported.
First 'data' event doesn't have to give a chunk with the whole message header.
This implementation is not only simple, but wrong.
@sequoiar
Copy link
Owner

appreciate pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sequoiar @reverofevil