Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchSort does not support "property" field patterns #87

Open
ontolojoy opened this issue Mar 25, 2023 · 4 comments
Open

SearchSort does not support "property" field patterns #87

ontolojoy opened this issue Mar 25, 2023 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@ontolojoy
Copy link

Instead it has a "timestamp:String" field. I believe this to be a simple typo.

@seratch seratch added the question Further information is requested label Mar 25, 2023
@seratch
Copy link
Owner

seratch commented Mar 25, 2023

Hi @ontolojoy, which part of this SDK are you talking about? When it comes to the search sort in search API request, it has both: https://github.com/seratch/notion-sdk-jvm/blob/v1.8.0/core/src/main/kotlin/notion/api/v1/request/search/SearchRequest.kt#L22-L27

@ontolojoy
Copy link
Author

Hi @ontolojoy, which part of this SDK are you talking about? When it comes to the search sort in search API request, it has both: https://github.com/seratch/notion-sdk-jvm/blob/v1.8.0/core/src/main/kotlin/notion/api/v1/request/search/SearchRequest.kt#L22-L27

Sorry, I mistyped as well. It contains "timestamp". It does not contain "property".
https://developers.notion.com/reference/post-database-query-sort

@seratch seratch added bug Something isn't working good first issue Good for newcomers and removed question Further information is requested labels Apr 3, 2023
@seratch
Copy link
Owner

seratch commented Apr 3, 2023

Thanks for sharing this. Perhaps, the property support might be added later on. We can support the pattern in future versions.

@seratch seratch changed the title SearchSort appears to be missing "direction" field SearchSort does not support "property" field patterns Apr 3, 2023
@seratch seratch added this to the 1.x milestone Apr 3, 2023
@sharmaudit124
Copy link

sharmaudit124 commented Sep 1, 2023

Hello @seratch, I was wondering if there is a contribution document available for reference when contributing to this repository. I'm relatively new to this, and having some guidance on setting up the local environment and other essential steps would be immensely helpful. Thank you for your assistance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants